From: "Enrico Jörns" <ejo@pengutronix.de>
To: oss-tools@pengutronix.de
Subject: [OSS-Tools] [PATCH dt-utils 2/5] state: helpful error message if state GUID cannot be found
Date: Tue, 27 Jan 2026 13:12:58 +0100 [thread overview]
Message-ID: <20260127121322.3332573-2-ejo@pengutronix.de> (raw)
In-Reply-To: <20260127121322.3332573-1-ejo@pengutronix.de>
Port of barebox commit:
| state: helpful error message if state GUID cannot be found
|
| So far, if the user didn't specify a valid GPT UID, state initialization
| failed with the not so helpful error message:
|
| | ERROR: state state.of: probe failed: Invalid argument
|
| Improve this by also providing a helpful error message.
|
| Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
| Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
| Link: https://lore.barebox.org/20260113132444.3808198-1-ejo@pengutronix.de
| Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
---
src/barebox-state/state.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/barebox-state/state.c b/src/barebox-state/state.c
index 3b02624..851f595 100644
--- a/src/barebox-state/state.c
+++ b/src/barebox-state/state.c
@@ -646,6 +646,7 @@ struct state *state_new_from_node(struct device_node *node, bool readonly)
if (cdev_is_block_disk(cdev)) {
cdev = cdev_find_child_by_gpt_typeuuid(cdev, &barebox_state_partition_guid);
if (IS_ERR(cdev)) {
+ dev_err(&state->dev, "cannot find backend GPT partition by PartitionTypeGUID\n");
ret = -EINVAL;
goto out_release_state;
}
--
2.47.3
next prev parent reply other threads:[~2026-01-27 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 12:12 [OSS-Tools] [PATCH dt-utils 1/5] meson.build: fix building with -Dbarebox-state=false Enrico Jörns
2026-01-27 12:12 ` Enrico Jörns [this message]
2026-01-27 12:12 ` [OSS-Tools] [PATCH dt-utils 3/5] libdt: error handling for udev read of ID_PART_TABLE_TYPE Enrico Jörns
2026-01-27 12:13 ` [OSS-Tools] [PATCH dt-utils 4/5] libdt: print error if device is not GPT-partitioned Enrico Jörns
2026-01-27 12:13 ` [OSS-Tools] [PATCH dt-utils 5/5] libdt: print error for failed udev_new() for consistency Enrico Jörns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127121322.3332573-2-ejo@pengutronix.de \
--to=ejo@pengutronix.de \
--cc=oss-tools@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox