mailarchive of the pengutronix oss-tools mailing list
 help / color / mirror / Atom feed
From: "Enrico Jörns" <ejo@pengutronix.de>
To: oss-tools@pengutronix.de
Subject: [OSS-Tools] [PATCH dt-utils 4/5] libdt: print error if device is not GPT-partitioned
Date: Tue, 27 Jan 2026 13:13:00 +0100	[thread overview]
Message-ID: <20260127121322.3332573-4-ejo@pengutronix.de> (raw)
In-Reply-To: <20260127121322.3332573-1-ejo@pengutronix.de>

This might really help debugging. Since we cannot differentiate between
not detecting the type properly and detecting it is not GPT, use a
wording that indicates this.

Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
---
 src/libdt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/libdt.c b/src/libdt.c
index 1bef154..f51ed17 100644
--- a/src/libdt.c
+++ b/src/libdt.c
@@ -2817,8 +2817,10 @@ struct cdev *cdev_find_child_by_gpt_typeuuid(struct cdev *cdev, guid_t *typeuuid
 	int ret;
 
 
-	if (!cdev->is_gpt_partitioned)
+	if (!cdev->is_gpt_partitioned) {
+		fprintf(stderr, "%s is not detected as GPT-partitioned\n", cdev->devpath);
 		return ERR_PTR(-EINVAL);
+	}
 
 	udev = udev_new();
 	if (!udev)
-- 
2.47.3




  parent reply	other threads:[~2026-01-27 12:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27 12:12 [OSS-Tools] [PATCH dt-utils 1/5] meson.build: fix building with -Dbarebox-state=false Enrico Jörns
2026-01-27 12:12 ` [OSS-Tools] [PATCH dt-utils 2/5] state: helpful error message if state GUID cannot be found Enrico Jörns
2026-01-27 12:12 ` [OSS-Tools] [PATCH dt-utils 3/5] libdt: error handling for udev read of ID_PART_TABLE_TYPE Enrico Jörns
2026-01-27 12:13 ` Enrico Jörns [this message]
2026-01-27 12:13 ` [OSS-Tools] [PATCH dt-utils 5/5] libdt: print error for failed udev_new() for consistency Enrico Jörns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260127121322.3332573-4-ejo@pengutronix.de \
    --to=ejo@pengutronix.de \
    --cc=oss-tools@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox