mailarchive of the pengutronix oss-tools mailing list
 help / color / mirror / Atom feed
From: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
Cc: oss-tools@pengutronix.de, m.felsch@pengutronix.de
Subject: Re: [OSS-Tools] [PATCH platsch V3 1/4] platsch: constify draw_buffer
Date: Fri, 14 Jun 2024 07:30:26 +0200	[thread overview]
Message-ID: <6rwmmsnlal.fsf@pengutronix.de> (raw)
In-Reply-To: <20240613070724.3400651-1-Qing-wu.Li@leica-geosystems.com.cn> (LI Qingwu's message of "Thu, 13 Jun 2024 09:07:21 +0200")

Hi Qingwu Li,

On Thu, Jun 13 2024 at 09:07 +0200, LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn> wrote:
> From: Marco Felsch <m.felsch@pengutronix.de>
>
> Make the dir and base const.
>
> Upstream-Status: Pending

please drop the last line, it is only required in the context of a
Yocto-BSP.

Best regards
Ulrich


> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  platsch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/platsch.c b/platsch.c
> index 535b589..1aaa8d5 100644
> --- a/platsch.c
> +++ b/platsch.c
> @@ -111,7 +111,7 @@ struct modeset_dev {
>  	uint32_t crtc_id;
>  };
>  
> -void draw_buffer(struct modeset_dev *dev, char *dir, char *base)
> +void draw_buffer(struct modeset_dev *dev, const char *dir, const char *base)
>  {
>  	int fd_src;
>  	char filename[128];
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      parent reply	other threads:[~2024-06-14  5:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13  7:07 LI Qingwu
2024-06-13  7:07 ` [OSS-Tools] [PATCH platsch V3 2/4] convert to meson build LI Qingwu
2024-06-13  8:44   ` Michael Tretter
2024-06-14  5:52   ` Ulrich Ölmann
2024-06-13  7:07 ` [OSS-Tools] [PATCH platsch V3 3/4] platsch: split into platsch and libplatsch LI Qingwu
2024-06-14 10:57   ` Ulrich Ölmann
2024-06-17  6:44     ` LI Qingwu
2024-06-13  7:07 ` [OSS-Tools] [PATCH platsch V3 4/4] Add spinner executable for boot animation and text show LI Qingwu
2024-06-14  5:30 ` Ulrich Ölmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6rwmmsnlal.fsf@pengutronix.de \
    --to=u.oelmann@pengutronix.de \
    --cc=Qing-wu.Li@leica-geosystems.com.cn \
    --cc=m.felsch@pengutronix.de \
    --cc=oss-tools@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox