From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 02 Apr 2024 16:44:38 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rrfNO-003jmC-1n for lore@lore.pengutronix.de; Tue, 02 Apr 2024 16:44:38 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rrfNN-00050u-Bk; Tue, 02 Apr 2024 16:44:37 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rrfNJ-00050e-T5; Tue, 02 Apr 2024 16:44:33 +0200 Message-ID: <9339ba89-2804-4457-b67f-2ce330a63ad7@pengutronix.de> Date: Tue, 2 Apr 2024 16:44:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , oss-tools@pengutronix.de References: <20240402130939.612353-2-u.kleine-koenig@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20240402130939.612353-2-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [OSS-Tools] [PATCH dt-utils] dtblint: add support for fsl, imx8mp-iomuxc X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Uwe, thanks for your patch. On 02.04.24 15:09, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König Please add the version of the reference manual you took these values from. > --- > src/dtblint-imx-pinmux.c | 1317 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 1317 insertions(+) > > + .padname = "SD1_DATA5", > + .swmux_regoffset = 0x0a8, > + .swmux_reset_default = 0x00000005, > + .swmux_writeable_mask = 0x00000017, > + .swpad_regoffset = 0x308, > + .swpad_reset_default = 0x00000106, > + .swpad_writeable_mask = 0x000001f6, > + .swpad_writeable_mask = 0x000001f6, This line is duplicated. > + .padname = "ECSPI2_SS0", > + .swmux_regoffset = 0x1fc, > + .swmux_reset_default = 0x00000005, > + .swmux_writeable_mask = 0x00000017, > + .swpad_regoffset = 0x45c, > + .swpad_reset_default = 0x00000106, > + .swpad_writeable_mask = 0x000001f6, > + .swpad_writeable_mask = 0x000001f6, This is also duplicated. > + /* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_0" regoffset=0x4c0 reset_default=0x00000000 */ > + /* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_1" regoffset=0x4c4 reset_default=0x00000000 */ > + /* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_2" regoffset=0x4c8 reset_default=0x00000000 */ > + /* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_3" regoffset=0x4cc reset_default=0x00000000 */ [snip] > + /* regname="USDHC3_STROBE_SELECT_INPUT" regoffset=0x630 reset_default=0x00000000 */ > + /* regname="USDHC3_WP_ON_SELECT_INPUT" regoffset=0x634 reset_default=0x00000000 */ What are these comments about? Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |