mailarchive of the pengutronix oss-tools mailing list
 help / color / mirror / Atom feed
From: Enrico Joerns <ejo@pengutronix.de>
To: chf.fritz@googlemail.com, Roland Hieber <rhi@pengutronix.de>
Cc: oss-tools@pengutronix.de, entwicklung <entwicklung@pengutronix.de>
Subject: Re: [OSS-Tools] [PATCH dt-utils] barebox-mark-successful-boot: adopt naming from barebox
Date: Wed, 11 Dec 2019 12:25:11 +0100
Message-ID: <9c217e15-b649-0457-3001-ad49e1461004@pengutronix.de> (raw)
In-Reply-To: <1573908272.2548.2.camel@googlemail.com>

On 11/16/19 1:44 PM, Christoph Fritz wrote:
> This patch is adopting current barebox default naming scheme.
> 
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> ---
>   scripts/barebox-mark-successful-boot.sh | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/barebox-mark-successful-boot.sh b/scripts/barebox-mark-successful-boot.sh
> index 3120f57..9286a63 100644
> --- a/scripts/barebox-mark-successful-boot.sh
> +++ b/scripts/barebox-mark-successful-boot.sh
> @@ -3,12 +3,12 @@
>   DEFAULT_REMAINING_ATTEMPTS=3
>   DEFAULT_PRIORITY=20
>   
> -system=$(sed /proc/cmdline -ne "s/\(^\|.* \)bootstate.active=\([^ ]*\).*/\2/p")
> +system=$(sed /proc/cmdline -ne "s/\(^\|.* \)bootchooser.active=\([^ ]*\).*/\2/p")
>   if [ -z "${system}" ]; then
>   	echo "unable to detect system partition" >&2
>   	exit 1
>   fi
>   
> -barebox-state -n /state \
> +barebox-state -n state \
>   	-s "bootstate.${system}.remaining_attempts=${DEFAULT_REMAINING_ATTEMPTS}" \
>   	-s "bootstate.${system}.priority=${DEFAULT_PRIORITY}"
> 

Thanks for your patch, I didn't even remember that we have a script for this ;)

For me, the changes look reasonable. Any concerns? Roland?


Enrico

-- 
Pengutronix e.K.                    | Enrico Jörns                |
Embedded Linux Consulting & Support | Teamleiter Integration      |
Steuerwalder Str. 21                | http://www.pengutronix.de/  |
31137 Hildesheim, Germany           | Phone: +49-5121-206917-5080 |
Amtsgericht Hildesheim, HRA 2686    | Fax:   +49-5121-206917-5555 |


_______________________________________________
OSS-Tools mailing list
OSS-Tools@pengutronix.de

  reply	other threads:[~2019-12-11 11:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-16 12:44 Christoph Fritz
2019-12-11 11:25 ` Enrico Joerns [this message]
2019-12-12 11:50   ` Roland Hieber
2019-12-12 12:07     ` Roland Hieber
2019-12-13 12:23       ` Christoph Fritz
2020-01-19 23:19         ` Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c217e15-b649-0457-3001-ad49e1461004@pengutronix.de \
    --to=ejo@pengutronix.de \
    --cc=chf.fritz@googlemail.com \
    --cc=entwicklung@pengutronix.de \
    --cc=oss-tools@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mailarchive of the pengutronix oss-tools mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.pengutronix.de/oss-tools/0 oss-tools/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 oss-tools oss-tools/ https://lore.pengutronix.de/oss-tools \
		oss-tools@pengutronix.de
	public-inbox-index oss-tools

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git