Re: [OSS-Tools] [PATCH dt-utils] dtblint: add support for fsl, imx8mp-iomuxc

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Uwe,

On 02.04.24 17:08, Uwe Kleine-König wrote:
>>> +	/* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_0" regoffset=0x4c0 reset_default=0x00000000 */
>>> +	/* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_1" regoffset=0x4c4 reset_default=0x00000000 */
>>> +	/* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_2" regoffset=0x4c8 reset_default=0x00000000 */
>>> +	/* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_3" regoffset=0x4cc reset_default=0x00000000 */
>>
>> [snip]
>>
>>> +	/* regname="USDHC3_STROBE_SELECT_INPUT" regoffset=0x630 reset_default=0x00000000 */
>>> +	/* regname="USDHC3_WP_ON_SELECT_INPUT" regoffset=0x634 reset_default=0x00000000 */
>>
>> What are these comments about?
> 
> The table of swmux and swpad registers originates from the reference
> manual. These comments are the registers in the IOMUXC that are not
> relevant for the linter. I kept them because copying these details from
> the NXP pdf isn't trivial. I can drop them if they are considered to be
> useless here.

You can leave them in, but please add a leading comment saying that these
pins are not muxable, so it's clear why they are commented out.

Thanks,
Ahmad

> 
> Best regards
> Uwe
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |