Re: [OSS-Tools] [PATCH platsch V5 3/5] platsch: split into platsch and libplatsch

[Philipp Zabel <p.zabel@pengutronix.de>]

On Mi, 2024-06-19 at 12:22 +0200, LI Qingwu wrote:
> Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> ---
>  libplatsch.c | 563 +++++++++++++++++++++++++++++++++++++++++++++++++
>  libplatsch.h |  47 +++++
>  meson.build  |  12 +-
>  platsch.c    | 582 ++-------------------------------------------------
>  4 files changed, 639 insertions(+), 565 deletions(-)
>  create mode 100644 libplatsch.c
>  create mode 100644 libplatsch.h
> 
> diff --git a/libplatsch.c b/libplatsch.c
> new file mode 100644
> index 0000000..2e0dc41
> --- /dev/null
> +++ b/libplatsch.c
> @@ -0,0 +1,563 @@
> +/*
> + * Copyright (C) 2019 Pengutronix, Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> + *
> + * Permission to use, copy, modify, and/or distribute this software
> + * for any purpose with or without fee is hereby granted.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL
> + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED
> + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE
> + * AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR
> + * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS
> + * OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT,
> + * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
> + * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
> + *
> + * Some code parts base on example code written in 2012 by David Herrmann
> + * <dh.herrmann@googlemail.com> and dedicated to the Public Domain. It was found
> + * in 2019 on
> + * https://raw.githubusercontent.com/dvdhrm/docs/master/drm-howto/modeset.c
> + */
> +
> +#include <assert.h>
> +#include <ctype.h>
> +#include <errno.h>
> +#include <getopt.h>

Please double check the needed headers. At least getopt code stayed in
platsch.c, and I think libgen.h, stdarg.h, stdbool.h, sys/types.h, and
sys/stat.h are not needed either.

> +#include <libgen.h>
> +#include <stdarg.h>
> +#include <stdbool.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include <unistd.h>
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +#include <sys/mman.h>
> +#include <fcntl.h>

regards
Philipp