From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 20 Jun 2024 14:55:23 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sKHJz-009GAy-0n for lore@lore.pengutronix.de; Thu, 20 Jun 2024 14:55:23 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sKHJy-0007n5-0i; Thu, 20 Jun 2024 14:55:22 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKHJv-0007ml-RM; Thu, 20 Jun 2024 14:55:19 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sKHJv-003hmx-9F; Thu, 20 Jun 2024 14:55:19 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1sKHJv-0009LC-0j; Thu, 20 Jun 2024 14:55:19 +0200 Message-ID: From: Philipp Zabel To: LI Qingwu , oss-tools@pengutronix.de, m.felsch@pengutronix.de Date: Thu, 20 Jun 2024 14:55:19 +0200 In-Reply-To: <20240619102227.2013556-3-Qing-wu.Li@leica-geosystems.com.cn> References: <20240619102227.2013556-1-Qing-wu.Li@leica-geosystems.com.cn> <20240619102227.2013556-3-Qing-wu.Li@leica-geosystems.com.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Subject: Re: [OSS-Tools] [PATCH platsch V5 3/5] platsch: split into platsch and libplatsch X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bsp-development.geo@leica-geosystems.com Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Mi, 2024-06-19 at 12:22 +0200, LI Qingwu wrote: > Signed-off-by: LI Qingwu > --- > libplatsch.c | 563 +++++++++++++++++++++++++++++++++++++++++++++++++ > libplatsch.h | 47 +++++ > meson.build | 12 +- > platsch.c | 582 ++------------------------------------------------- > 4 files changed, 639 insertions(+), 565 deletions(-) > create mode 100644 libplatsch.c > create mode 100644 libplatsch.h >=20 > diff --git a/libplatsch.c b/libplatsch.c > new file mode 100644 > index 0000000..2e0dc41 > --- /dev/null > +++ b/libplatsch.c > @@ -0,0 +1,563 @@ > +/* > + * Copyright (C) 2019 Pengutronix, Uwe Kleine-K=C3=B6nig > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > + * AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR > + * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS > + * OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, > + * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN > + * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. > + * > + * Some code parts base on example code written in 2012 by David Herrman= n > + * and dedicated to the Public Domain. It w= as found > + * in 2019 on > + * https://raw.githubusercontent.com/dvdhrm/docs/master/drm-howto/modese= t.c > + */ > + > +#include > +#include > +#include > +#include Please double check the needed headers. At least getopt code stayed in platsch.c, and I think libgen.h, stdarg.h, stdbool.h, sys/types.h, and sys/stat.h are not needed either. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include regards Philipp