From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 14 Jun 2024 15:34:59 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sI751-005x5D-0i for lore@lore.pengutronix.de; Fri, 14 Jun 2024 15:34:59 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sI74z-0001tQ-UK; Fri, 14 Jun 2024 15:34:57 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sI74y-0001sV-AN; Fri, 14 Jun 2024 15:34:56 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sI74x-002HQr-QL; Fri, 14 Jun 2024 15:34:55 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1sI74x-0008uq-2R; Fri, 14 Jun 2024 15:34:55 +0200 Message-ID: From: Philipp Zabel To: LI Qingwu , oss-tools@pengutronix.de, m.felsch@pengutronix.de Date: Fri, 14 Jun 2024 15:34:55 +0200 In-Reply-To: <20240614092308.1429018-2-Qing-wu.Li@leica-geosystems.com.cn> References: <20240614092308.1429018-1-Qing-wu.Li@leica-geosystems.com.cn> <20240614092308.1429018-2-Qing-wu.Li@leica-geosystems.com.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Subject: Re: [OSS-Tools] [PATCH platsch V4 2/4] convert to meson build X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hi, On Fr, 2024-06-14 at 11:23 +0200, LI Qingwu wrote: > Convert to meson build and update the README.rst I'd note the version update to 2024.06.0 in the commit description. > Signed-off-by: LI Qingwu > --- > Makefile.am | 23 ----------------------- > README.rst | 8 ++++++++ > configure.ac | 13 ------------- > meson.build | 15 +++++++++++++++ Please also update .gitignore, I think none of the current entries are needed anymore after this change. > 4 files changed, 23 insertions(+), 36 deletions(-) > delete mode 100644 Makefile.am > delete mode 100644 configure.ac > create mode 100644 meson.build >=20 > diff --git a/Makefile.am b/Makefile.am > deleted file mode 100644 > index d149ae0..0000000 > --- a/Makefile.am > +++ /dev/null > @@ -1,23 +0,0 @@ > -EXTRA_DIST =3D README.rst LICENSE > - > -sbin_PROGRAMS =3D platsch > - > -platsch_SOURCES =3D platsch.c > -platsch_CFLAGS =3D $(LIBDRM_CFLAGS) > -platsch_LDADD =3D $(LIBDRM_LIBS) > - > -CLEANFILES =3D \ > - $(DIST_ARCHIVES) > - > -DISTCLEAN =3D \ > - config.log \ > - config.status \ > - Makefile > - > -MAINTAINERCLEANFILES =3D \ > - aclocal.m4 \ > - configure \ > - depcomp \ > - install-sh \ > - Makefile.in \ > - missing > diff --git a/README.rst b/README.rst > index e318120..f1c0812 100644 > --- a/README.rst > +++ b/README.rst > @@ -141,3 +141,11 @@ By adding a Signed-off-by line (e.g. using ``git com= mit -s``) saying:: > =20 > (using your real name and e-mail address), you state that your contribut= ions > are in line with the DCO. > + > +Compiling Instructions > +---------------------------- > + > +.. code-block:: shell > + > + meson setup build > + meson compile -C build > diff --git a/configure.ac b/configure.ac > deleted file mode 100644 > index 18878db..0000000 > --- a/configure.ac > +++ /dev/null > @@ -1,13 +0,0 @@ > -AC_PREREQ([2.69]) > -AC_INIT([platsch], [2019.12.0], [oss-tools@pengutronix.de]) > -AC_CONFIG_SRCDIR([platsch.c]) > -AM_INIT_AUTOMAKE([foreign dist-xz]) > - > -AC_PROG_CC > -AC_PROG_MAKE_SET > - > -PKG_CHECK_MODULES([LIBDRM], [libdrm >=3D 2.4.112]) > - > -AC_CONFIG_FILES([Makefile]) > - > -AC_OUTPUT > diff --git a/meson.build b/meson.build > new file mode 100644 > index 0000000..0aadbe9 > --- /dev/null > +++ b/meson.build > @@ -0,0 +1,15 @@ > +project('platsch', 'c', version: '2024.06.0') license : '0BSD', > +dep_libdrm =3D dependency('libdrm', version : '>=3D 2.4.112', required := true) Drop "required : true", it is the default. > +sources =3D ['platsch.c'] > + > +# Define the headers > +headers =3D ['platsch.h'] This is never used, and platsch.h doesn't exist. Just drop it. > + > +# Create the platsch executable This comment doesn't add any valuable information, compared to the line right below: > +executable('platsch', > + sources, > + dependencies: dep_libdrm, > + install: true, This was "sbin_PROGRAMS =3D platsch", so install to ${prefix}/sbin: install_dir : 'sbin', > + include_directories: include_directories('.') This is not needed. > +) regards Philipp