From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 02 Apr 2024 17:08:37 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rrfkb-003m25-0T for lore@lore.pengutronix.de; Tue, 02 Apr 2024 17:08:37 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rrfkZ-0003RK-Nd; Tue, 02 Apr 2024 17:08:35 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rrfkZ-0003R5-4B; Tue, 02 Apr 2024 17:08:35 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rrfkY-00A0JS-O1; Tue, 02 Apr 2024 17:08:34 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rrfkY-00EPKw-29; Tue, 02 Apr 2024 17:08:34 +0200 Date: Tue, 2 Apr 2024 17:08:34 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Ahmad Fatoum Message-ID: References: <20240402130939.612353-2-u.kleine-koenig@pengutronix.de> <9339ba89-2804-4457-b67f-2ce330a63ad7@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tsnh3ras4czmcerw" Content-Disposition: inline In-Reply-To: <9339ba89-2804-4457-b67f-2ce330a63ad7@pengutronix.de> Subject: Re: [OSS-Tools] [PATCH dt-utils] dtblint: add support for fsl, imx8mp-iomuxc X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oss-tools@pengutronix.de Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false --tsnh3ras4czmcerw Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Ahmad, On Tue, Apr 02, 2024 at 04:44:33PM +0200, Ahmad Fatoum wrote: > On 02.04.24 15:09, Uwe Kleine-K=F6nig wrote: > > Signed-off-by: Uwe Kleine-K=F6nig >=20 > Please add the version of the reference manual you took these values from. Good idea. I'd even add it to the source file, too. > > --- > > src/dtblint-imx-pinmux.c | 1317 ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 1317 insertions(+) > >=20 >=20 > > + .padname =3D "SD1_DATA5", > > + .swmux_regoffset =3D 0x0a8, > > + .swmux_reset_default =3D 0x00000005, > > + .swmux_writeable_mask =3D 0x00000017, > > + .swpad_regoffset =3D 0x308, > > + .swpad_reset_default =3D 0x00000106, > > + .swpad_writeable_mask =3D 0x000001f6, > > + .swpad_writeable_mask =3D 0x000001f6, >=20 > This line is duplicated. Yes, this is fixed in v2, together with two other such duplicates. > > + .padname =3D "ECSPI2_SS0", > > + .swmux_regoffset =3D 0x1fc, > > + .swmux_reset_default =3D 0x00000005, > > + .swmux_writeable_mask =3D 0x00000017, > > + .swpad_regoffset =3D 0x45c, > > + .swpad_reset_default =3D 0x00000106, > > + .swpad_writeable_mask =3D 0x000001f6, > > + .swpad_writeable_mask =3D 0x000001f6, >=20 > This is also duplicated. >=20 > > + /* regname=3D"AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_0" regoffse= t=3D0x4c0 reset_default=3D0x00000000 */ > > + /* regname=3D"AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_1" regoffse= t=3D0x4c4 reset_default=3D0x00000000 */ > > + /* regname=3D"AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_2" regoffse= t=3D0x4c8 reset_default=3D0x00000000 */ > > + /* regname=3D"AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_3" regoffse= t=3D0x4cc reset_default=3D0x00000000 */ >=20 > [snip] >=20 > > + /* regname=3D"USDHC3_STROBE_SELECT_INPUT" regoffset=3D0x630 reset_def= ault=3D0x00000000 */ > > + /* regname=3D"USDHC3_WP_ON_SELECT_INPUT" regoffset=3D0x634 reset_defa= ult=3D0x00000000 */ >=20 > What are these comments about? The table of swmux and swpad registers originates from the reference manual. These comments are the registers in the IOMUXC that are not relevant for the linter. I kept them because copying these details from the NXP pdf isn't trivial. I can drop them if they are considered to be useless here. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --tsnh3ras4czmcerw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYMH3EACgkQj4D7WH0S /k7wkgf+LmVgOLTBe3GezgZZucm8W7jx7SiR3qaY2sTIczRhnR3Vk2g0hGPACLbC uiGHZanpiFhWIxUB/QvaPzz9HEttD1dnL5H+kC+6ww9EF9p21tMHOi6wi5nBSAp0 qTZYNchJ8J6wwi+vrpwhg5fBXkpPJn3gNCWuUOQshhs/v35ukIDbKysLVCqsLn96 +Qqd1HgdGwuvpupljLTJgdTaGY82FKWwUUUlcb2J8R/KDwGw+K+rKVZc3vTJExY0 D6h/gMe6h/aIj2mgrRDSx9Coi+OzCHm0ufMCUXVWySc5JkgDT3sQPzJXV9X6G8tp CHOLzjRlUrMiy2FTM2A6vKcMjLnJnw== =Ke2Z -----END PGP SIGNATURE----- --tsnh3ras4czmcerw--