mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ddr: imx: hide config prompt unless COMPILE_TEST
@ 2024-04-23  6:00 Ahmad Fatoum
  2024-04-23  6:24 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2024-04-23  6:00 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

The DDR drivers are called into by low-level code for DRAM init.
The Kconfig options for them are selected by the SOC symbols, e.g.
ARCH_IMX8M and there's no point in asking for user decision: either
it's required and already selected or it will be unused and subject
to linker garbage collection. Therefore, hide the prompts by default.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/ddr/imx/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ddr/imx/Kconfig b/drivers/ddr/imx/Kconfig
index 71d4144e856e..ec6c097ec9f6 100644
--- a/drivers/ddr/imx/Kconfig
+++ b/drivers/ddr/imx/Kconfig
@@ -7,10 +7,10 @@ config IMX_DRAM
 
 config IMX8M_DRAM
 	select IMX_DRAM
-	bool "imx8m dram controller support"
+	bool "imx8m dram controller support" if COMPILE_TEST
 
 config IMX9_DRAM
 	select IMX_DRAM
-	bool "imx9 dram controller support"
+	bool "imx9 dram controller support" if COMPILE_TEST
 
 endmenu
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ddr: imx: hide config prompt unless COMPILE_TEST
  2024-04-23  6:00 [PATCH] ddr: imx: hide config prompt unless COMPILE_TEST Ahmad Fatoum
@ 2024-04-23  6:24 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-04-23  6:24 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Tue, 23 Apr 2024 08:00:46 +0200, Ahmad Fatoum wrote:
> The DDR drivers are called into by low-level code for DRAM init.
> The Kconfig options for them are selected by the SOC symbols, e.g.
> ARCH_IMX8M and there's no point in asking for user decision: either
> it's required and already selected or it will be unused and subject
> to linker garbage collection. Therefore, hide the prompts by default.
> 
> 
> [...]

Applied, thanks!

[1/1] ddr: imx: hide config prompt unless COMPILE_TEST
      https://git.pengutronix.de/cgit/barebox/commit/?id=8028c9f2d564 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-23  6:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-23  6:00 [PATCH] ddr: imx: hide config prompt unless COMPILE_TEST Ahmad Fatoum
2024-04-23  6:24 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox