mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] mtd: nand: stm32: fix wrong regmap_bulk_read() usage
@ 2024-04-16  6:08 Sascha Hauer
  2024-04-17  6:22 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Sascha Hauer @ 2024-04-16  6:08 UTC (permalink / raw)
  To: Barebox List

Compilation of the STM32 NAND driver fails with:

error: call to '__regmap_bulk_api_changed' declared with attribute error: Last argument is now number of registers, not bytes. Fix it and include <linux/regmap.h instead

Do exactly this to make the driver compile again

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mtd/nand/stm32_fmc2_nand.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/stm32_fmc2_nand.c b/drivers/mtd/nand/stm32_fmc2_nand.c
index 958a619be5..47b012cc9e 100644
--- a/drivers/mtd/nand/stm32_fmc2_nand.c
+++ b/drivers/mtd/nand/stm32_fmc2_nand.c
@@ -7,7 +7,7 @@
 #include <common.h>
 #include <init.h>
 #include <of_address.h>
-#include <regmap.h>
+#include <linux/regmap.h>
 #include <linux/bitfield.h>
 #include <linux/clk.h>
 #include <linux/gpio/consumer.h>
@@ -551,7 +551,7 @@ static int stm32_fmc2_nfc_bch_correct(struct nand_chip *chip, u8 *dat,
 		return -ETIMEDOUT;
 	}
 
-	regmap_bulk_read(nfc->regmap, FMC2_BCHDSR0, ecc_sta, 5);
+	regmap_bulk_read(nfc->regmap, FMC2_BCHDSR0, ecc_sta, ARRAY_SIZE(ecc_sta));
 
 	stm32_fmc2_nfc_set_ecc(nfc, false);
 
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd: nand: stm32: fix wrong regmap_bulk_read() usage
  2024-04-16  6:08 [PATCH] mtd: nand: stm32: fix wrong regmap_bulk_read() usage Sascha Hauer
@ 2024-04-17  6:22 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-04-17  6:22 UTC (permalink / raw)
  To: Barebox List, Sascha Hauer


On Tue, 16 Apr 2024 08:08:06 +0200, Sascha Hauer wrote:
> Compilation of the STM32 NAND driver fails with:
> 
> error: call to '__regmap_bulk_api_changed' declared with attribute error: Last argument is now number of registers, not bytes. Fix it and include <linux/regmap.h instead
> 
> Do exactly this to make the driver compile again
> 
> 
> [...]

Applied, thanks!

[1/1] mtd: nand: stm32: fix wrong regmap_bulk_read() usage
      https://git.pengutronix.de/cgit/barebox/commit/?id=760f14774fcd (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-17  6:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-16  6:08 [PATCH] mtd: nand: stm32: fix wrong regmap_bulk_read() usage Sascha Hauer
2024-04-17  6:22 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox