mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] images: remove unused FIT.ITS rule
@ 2026-10-15 14:03 Ahmad Fatoum
  2026-10-20 13:52 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2026-10-15 14:03 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

The rule building a FIT image from an .its file has had no users since
commit 7269ad4be96b ("ARM: k3: remove beagleplay FIT image").

Since the kbuild sync with Linux v6.17 moved dtc-tmp into
scripts/Makefile.dtbs, which isn't included for images/, the rule also
passes an empty file name to both the preprocessor and mkimage.

Remove the rule along with its .gitignore entry instead of fixing it.

Assisted-by: Claude:opus-5.5
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 images/.gitignore | 1 -
 images/Makefile   | 9 ---------
 2 files changed, 10 deletions(-)

diff --git a/images/.gitignore b/images/.gitignore
index 0e0d2fa71859..412587de5188 100644
--- a/images/.gitignore
+++ b/images/.gitignore
@@ -38,7 +38,6 @@ barebox.sum
 *.swapped
 *.rkimg
 *.imx9img
-*.itb
 *.fit
 *.missing-firmware
 *.k3img
diff --git a/images/Makefile b/images/Makefile
index 6b0feb27659d..2af2d17911fa 100644
--- a/images/Makefile
+++ b/images/Makefile
@@ -125,15 +125,6 @@ $(obj)/%.pblb: $(obj)/%.pbl FORCE
 $(obj)/%.s: $(obj)/% FORCE
 	$(call if_changed,disasm)
 
-quiet_cmd_itb = FIT.ITS $@
-cmd_itb = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) \
-	-D'$(subst -,_,$(*F))_dts=1' $(foreach f,$< $(2),-include '$(f)') /dev/null ; \
-	$(MKIMAGE) -f $(dtc-tmp) $@ -E \
-	cat $(depfile).pre $(depfile).dtc > $(depfile)
-
-$(obj)/%.itb: $(obj)/%.its FORCE
-	$(call if_changed,itb)
-
 .SECONDEXPANSION:
 $(obj)/%.fit: $(obj)/$$(FILE_$$(@F)) $(dtstree)/dtbs-list FORCE
 	$(call if_changed,fit)
-- 
2.47.3




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] images: remove unused FIT.ITS rule
  2026-10-15 14:03 [PATCH] images: remove unused FIT.ITS rule Ahmad Fatoum
@ 2026-10-20 13:52 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2026-10-20 13:52 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Thu, 15 Oct 2026 16:03:14 +0200, Ahmad Fatoum wrote:
> The rule building a FIT image from an .its file has had no users since
> commit 7269ad4be96b ("ARM: k3: remove beagleplay FIT image").
> 
> Since the kbuild sync with Linux v6.17 moved dtc-tmp into
> scripts/Makefile.dtbs, which isn't included for images/, the rule also
> passes an empty file name to both the preprocessor and mkimage.
> 
> [...]

Applied, thanks!

[1/1] images: remove unused FIT.ITS rule
      https://git.pengutronix.de/cgit/barebox/commit/?id=6f8e0d3ff8df (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-20 13:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-15 14:03 [PATCH] images: remove unused FIT.ITS rule Ahmad Fatoum
2026-10-20 13:52 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox