From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: Re: [PATCH] commands: truncate: report errors from ftruncate()
Date: Tue, 20 Oct 2026 15:57:29 +0200 [thread overview]
Message-ID: <179250464969.2719180.14477115254679718961.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20261015140812.1229929-1-a.fatoum@pengutronix.de>
On Thu, 15 Oct 2026 16:08:11 +0200, Ahmad Fatoum wrote:
> ftruncate() and fstat() return a negative error code, not -1, so the
> command only noticed an -EPERM and otherwise exited with 0 even when the
> file wasn't resized, e.g. on a size ubootvarfs has no room for.
>
> Let's check for any negative return value instead.
>
>
> [...]
Applied, thanks!
[1/1] commands: truncate: report errors from ftruncate()
https://git.pengutronix.de/cgit/barebox/commit/?id=d9ba097d957d (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-10-20 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 14:08 Ahmad Fatoum
2026-10-20 13:57 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179250464969.2719180.14477115254679718961.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox