mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] blspec: fix incompatible pointer type warning
@ 2014-11-06 14:10 Lucas Stach
  2014-11-07  7:00 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2014-11-06 14:10 UTC (permalink / raw)
  To: barebox

The warning is correct in that we pass in size_t instead
of int. As we are not interested in the size of the
property at this point, just remove the assignment.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 common/blspec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/blspec.c b/common/blspec.c
index a4adc48da967..f46a11d44c0e 100644
--- a/common/blspec.c
+++ b/common/blspec.c
@@ -294,7 +294,7 @@ static bool entry_is_of_compatible(struct blspec_entry *entry)
 	}
 
 	pr_info("ignoring entry with incompatible devicetree \"%s\"\n",
-			(char *)of_get_property(root, "compatible", &size));
+			(char *)of_get_property(root, "compatible", NULL));
 
 	ret = false;
 
-- 
2.1.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] blspec: fix incompatible pointer type warning
  2014-11-06 14:10 [PATCH] blspec: fix incompatible pointer type warning Lucas Stach
@ 2014-11-07  7:00 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2014-11-07  7:00 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On Thu, Nov 06, 2014 at 03:10:38PM +0100, Lucas Stach wrote:
> The warning is correct in that we pass in size_t instead
> of int. As we are not interested in the size of the
> property at this point, just remove the assignment.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Applied, thanks

Sascha

> ---
>  common/blspec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/blspec.c b/common/blspec.c
> index a4adc48da967..f46a11d44c0e 100644
> --- a/common/blspec.c
> +++ b/common/blspec.c
> @@ -294,7 +294,7 @@ static bool entry_is_of_compatible(struct blspec_entry *entry)
>  	}
>  
>  	pr_info("ignoring entry with incompatible devicetree \"%s\"\n",
> -			(char *)of_get_property(root, "compatible", &size));
> +			(char *)of_get_property(root, "compatible", NULL));
>  
>  	ret = false;
>  
> -- 
> 2.1.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-07  7:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-06 14:10 [PATCH] blspec: fix incompatible pointer type warning Lucas Stach
2014-11-07  7:00 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox