From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] param: drop unused left-over struct members
Date: Mon, 15 Mar 2021 08:48:23 +0100 [thread overview]
Message-ID: <20210315074823.GD23724@pengutronix.de> (raw)
In-Reply-To: <20210311103157.897-1-a.fatoum@pengutronix.de>
On Thu, Mar 11, 2021 at 11:31:57AM +0100, Ahmad Fatoum wrote:
> Both seem to be a copy-paste left-over from the int param. They are
> unused anywhere, so it's safe to just drop them.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> lib/parameter.c | 2 --
> 1 file changed, 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/lib/parameter.c b/lib/parameter.c
> index 1f768ab65ede..adc3c7cdea70 100644
> --- a/lib/parameter.c
> +++ b/lib/parameter.c
> @@ -749,7 +749,6 @@ struct param_d *dev_add_param_bitmask(struct device_d *dev, const char *name,
> struct param_ip {
> struct param_d param;
> IPaddr_t *ip;
> - const char *format;
> int (*set)(struct param_d *p, void *priv);
> int (*get)(struct param_d *p, void *priv);
> };
> @@ -828,7 +827,6 @@ struct param_mac {
> struct param_d param;
> char *mac;
> u8 mac_str[sizeof("xx:xx:xx:xx:xx:xx")];
> - const char *format;
> int (*set)(struct param_d *p, void *priv);
> int (*get)(struct param_d *p, void *priv);
> };
> --
> 2.29.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-03-15 7:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 10:31 Ahmad Fatoum
2021-03-15 7:48 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315074823.GD23724@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox