[PATCH] param: drop unused left-over struct members

[PATCH] param: drop unused left-over struct members

[Ahmad Fatoum]

Both seem to be a copy-paste left-over from the int param. They are
unused anywhere, so it's safe to just drop them.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 lib/parameter.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/parameter.c b/lib/parameter.c
index 1f768ab65ede..adc3c7cdea70 100644
--- a/lib/parameter.c
+++ b/lib/parameter.c
@@ -749,7 +749,6 @@ struct param_d *dev_add_param_bitmask(struct device_d *dev, const char *name,
 struct param_ip {
 	struct param_d param;
 	IPaddr_t *ip;
-	const char *format;
 	int (*set)(struct param_d *p, void *priv);
 	int (*get)(struct param_d *p, void *priv);
 };
@@ -828,7 +827,6 @@ struct param_mac {
 	struct param_d param;
 	char *mac;
 	u8 mac_str[sizeof("xx:xx:xx:xx:xx:xx")];
-	const char *format;
 	int (*set)(struct param_d *p, void *priv);
 	int (*get)(struct param_d *p, void *priv);
 };
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] param: drop unused left-over struct members

[Sascha Hauer]

On Thu, Mar 11, 2021 at 11:31:57AM +0100, Ahmad Fatoum wrote:
> Both seem to be a copy-paste left-over from the int param. They are
> unused anywhere, so it's safe to just drop them.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  lib/parameter.c | 2 --
>  1 file changed, 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/lib/parameter.c b/lib/parameter.c
> index 1f768ab65ede..adc3c7cdea70 100644
> --- a/lib/parameter.c
> +++ b/lib/parameter.c
> @@ -749,7 +749,6 @@ struct param_d *dev_add_param_bitmask(struct device_d *dev, const char *name,
>  struct param_ip {
>  	struct param_d param;
>  	IPaddr_t *ip;
> -	const char *format;
>  	int (*set)(struct param_d *p, void *priv);
>  	int (*get)(struct param_d *p, void *priv);
>  };
> @@ -828,7 +827,6 @@ struct param_mac {
>  	struct param_d param;
>  	char *mac;
>  	u8 mac_str[sizeof("xx:xx:xx:xx:xx:xx")];
> -	const char *format;
>  	int (*set)(struct param_d *p, void *priv);
>  	int (*get)(struct param_d *p, void *priv);
>  };
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox