mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] fs: delete unused members in <linux/stat.h>
@ 2021-03-12 11:40 Ahmad Fatoum
  2021-03-15  8:06 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2021-03-12 11:40 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Most of the struct is stuff we don't use and likely won't any
time soon. Drop them.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 fs/fs.c              |  1 -
 include/linux/stat.h | 12 ------------
 2 files changed, 13 deletions(-)

diff --git a/fs/fs.c b/fs/fs.c
index 3db24b7b6822..a5dbc3aac478 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -909,7 +909,6 @@ EXPORT_SYMBOL(readdir);
 
 static void stat_inode(struct inode *inode, struct stat *s)
 {
-	s->st_dev = 0;
 	s->st_ino = inode->i_ino;
 	s->st_mode = inode->i_mode;
 	s->st_uid = inode->i_uid;
diff --git a/include/linux/stat.h b/include/linux/stat.h
index 87fe06839671..f5043d8bcea7 100644
--- a/include/linux/stat.h
+++ b/include/linux/stat.h
@@ -45,8 +45,6 @@ extern "C" {
 #define S_IRWXUGO	(S_IRWXU|S_IRWXG|S_IRWXO)
 
 struct stat {
-	unsigned short st_dev;
-	unsigned short __pad1;
 	unsigned long st_ino;
 	unsigned short st_mode;
 	unsigned short st_nlink;
@@ -55,16 +53,6 @@ struct stat {
 	unsigned short st_rdev;
 	unsigned short __pad2;
 	loff_t  st_size;
-	unsigned long  st_blksize;
-	unsigned long  st_blocks;
-	unsigned long  st_atime;
-	unsigned long  __unused1;
-	unsigned long  st_mtime;
-	unsigned long  __unused2;
-	unsigned long  st_ctime;
-	unsigned long  __unused3;
-	unsigned long  __unused4;
-	unsigned long  __unused5;
 };
 
 #ifdef __cplusplus
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fs: delete unused members in <linux/stat.h>
  2021-03-12 11:40 [PATCH] fs: delete unused members in <linux/stat.h> Ahmad Fatoum
@ 2021-03-15  8:06 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2021-03-15  8:06 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Fri, Mar 12, 2021 at 12:40:27PM +0100, Ahmad Fatoum wrote:
> Most of the struct is stuff we don't use and likely won't any
> time soon. Drop them.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  fs/fs.c              |  1 -
>  include/linux/stat.h | 12 ------------
>  2 files changed, 13 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/fs/fs.c b/fs/fs.c
> index 3db24b7b6822..a5dbc3aac478 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -909,7 +909,6 @@ EXPORT_SYMBOL(readdir);
>  
>  static void stat_inode(struct inode *inode, struct stat *s)
>  {
> -	s->st_dev = 0;
>  	s->st_ino = inode->i_ino;
>  	s->st_mode = inode->i_mode;
>  	s->st_uid = inode->i_uid;
> diff --git a/include/linux/stat.h b/include/linux/stat.h
> index 87fe06839671..f5043d8bcea7 100644
> --- a/include/linux/stat.h
> +++ b/include/linux/stat.h
> @@ -45,8 +45,6 @@ extern "C" {
>  #define S_IRWXUGO	(S_IRWXU|S_IRWXG|S_IRWXO)
>  
>  struct stat {
> -	unsigned short st_dev;
> -	unsigned short __pad1;
>  	unsigned long st_ino;
>  	unsigned short st_mode;
>  	unsigned short st_nlink;
> @@ -55,16 +53,6 @@ struct stat {
>  	unsigned short st_rdev;
>  	unsigned short __pad2;
>  	loff_t  st_size;
> -	unsigned long  st_blksize;
> -	unsigned long  st_blocks;
> -	unsigned long  st_atime;
> -	unsigned long  __unused1;
> -	unsigned long  st_mtime;
> -	unsigned long  __unused2;
> -	unsigned long  st_ctime;
> -	unsigned long  __unused3;
> -	unsigned long  __unused4;
> -	unsigned long  __unused5;
>  };
>  
>  #ifdef __cplusplus
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-15  8:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 11:40 [PATCH] fs: delete unused members in <linux/stat.h> Ahmad Fatoum
2021-03-15  8:06 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox