* [PATCH] watchdog: imxwd: get and enable clock
@ 2021-04-19 12:37 Steffen Trumtrar
2021-05-03 11:43 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Steffen Trumtrar @ 2021-04-19 12:37 UTC (permalink / raw)
To: Barebox List
This it (at least) necessary for i.MX7s or otherwise barebox will hang
when trying to access the registers of WDOG2/3/4.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
drivers/watchdog/imxwd.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/watchdog/imxwd.c b/drivers/watchdog/imxwd.c
index b2cfd1cd3a31..26c62b7bcb31 100644
--- a/drivers/watchdog/imxwd.c
+++ b/drivers/watchdog/imxwd.c
@@ -21,6 +21,7 @@
#include <restart.h>
#include <watchdog.h>
#include <reset_source.h>
+#include <linux/clk.h>
struct imx_wd;
@@ -224,6 +225,7 @@ static int imx_wd_probe(struct device_d *dev)
{
struct resource *iores;
struct imx_wd *priv;
+ struct clk *clk;
void *ops;
int ret;
@@ -237,6 +239,15 @@ static int imx_wd_probe(struct device_d *dev)
dev_err(dev, "could not get memory region\n");
return PTR_ERR(iores);
}
+
+ clk = clk_get(dev, NULL);
+ if (IS_ERR(clk))
+ return PTR_ERR(clk);
+
+ ret = clk_enable(clk);
+ if (ret)
+ return ret;
+
priv->base = IOMEM(iores->start);
priv->ops = ops;
priv->wd.set_timeout = imx_watchdog_set_timeout;
--
2.29.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: imxwd: get and enable clock
2021-04-19 12:37 [PATCH] watchdog: imxwd: get and enable clock Steffen Trumtrar
@ 2021-05-03 11:43 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2021-05-03 11:43 UTC (permalink / raw)
To: Steffen Trumtrar; +Cc: Barebox List
On Mon, Apr 19, 2021 at 02:37:47PM +0200, Steffen Trumtrar wrote:
> This it (at least) necessary for i.MX7s or otherwise barebox will hang
> when trying to access the registers of WDOG2/3/4.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> drivers/watchdog/imxwd.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/drivers/watchdog/imxwd.c b/drivers/watchdog/imxwd.c
> index b2cfd1cd3a31..26c62b7bcb31 100644
> --- a/drivers/watchdog/imxwd.c
> +++ b/drivers/watchdog/imxwd.c
> @@ -21,6 +21,7 @@
> #include <restart.h>
> #include <watchdog.h>
> #include <reset_source.h>
> +#include <linux/clk.h>
>
> struct imx_wd;
>
> @@ -224,6 +225,7 @@ static int imx_wd_probe(struct device_d *dev)
> {
> struct resource *iores;
> struct imx_wd *priv;
> + struct clk *clk;
> void *ops;
> int ret;
>
> @@ -237,6 +239,15 @@ static int imx_wd_probe(struct device_d *dev)
> dev_err(dev, "could not get memory region\n");
> return PTR_ERR(iores);
> }
> +
> + clk = clk_get(dev, NULL);
> + if (IS_ERR(clk))
> + return PTR_ERR(clk);
> +
> + ret = clk_enable(clk);
> + if (ret)
> + return ret;
> +
> priv->base = IOMEM(iores->start);
> priv->ops = ops;
> priv->wd.set_timeout = imx_watchdog_set_timeout;
> --
> 2.29.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-03 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-19 12:37 [PATCH] watchdog: imxwd: get and enable clock Steffen Trumtrar
2021-05-03 11:43 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox