mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <>
To: Barebox List <>
Subject: [PATCH] ARM: at91: boot_test_cmd: Fix compiler warning
Date: Wed, 12 May 2021 07:50:34 +0200	[thread overview]
Message-ID: <> (raw)

Use a signed type to test against negative return values from write().
While at it, reduce the scope of 'tmp'.

Signed-off-by: Sascha Hauer <>
 arch/arm/mach-at91/boot_test_cmd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-at91/boot_test_cmd.c b/arch/arm/mach-at91/boot_test_cmd.c
index 4fd1998ad0..7bb40f2e40 100644
--- a/arch/arm/mach-at91/boot_test_cmd.c
+++ b/arch/arm/mach-at91/boot_test_cmd.c
@@ -24,7 +24,6 @@ static int do_at91_boot_test(int argc, char *argv[])
 	int ret = 1;
 	char *sram = "/dev/sram0";
 	u32 read_size, write_size;
-	u32 tmp = 0;
 	while ((opt = getopt(argc, argv, "j:s:")) > 0) {
 		switch (opt) {
@@ -64,7 +63,7 @@ static int do_at91_boot_test(int argc, char *argv[])
 	while (write_size) {
-		tmp = write(fd, buf, write_size);
+		int tmp = write(fd, buf, write_size);
 		if (tmp < 0) {
 			goto err_open;

barebox mailing list

                 reply	other threads:[~2021-05-12  5:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox