mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: at91: boot_test_cmd: Fix compiler warning
@ 2021-05-12  5:50 Sascha Hauer
  0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2021-05-12  5:50 UTC (permalink / raw)
  To: Barebox List

Use a signed type to test against negative return values from write().
While at it, reduce the scope of 'tmp'.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/mach-at91/boot_test_cmd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-at91/boot_test_cmd.c b/arch/arm/mach-at91/boot_test_cmd.c
index 4fd1998ad0..7bb40f2e40 100644
--- a/arch/arm/mach-at91/boot_test_cmd.c
+++ b/arch/arm/mach-at91/boot_test_cmd.c
@@ -24,7 +24,6 @@ static int do_at91_boot_test(int argc, char *argv[])
 	int ret = 1;
 	char *sram = "/dev/sram0";
 	u32 read_size, write_size;
-	u32 tmp = 0;
 
 	while ((opt = getopt(argc, argv, "j:s:")) > 0) {
 		switch (opt) {
@@ -64,7 +63,7 @@ static int do_at91_boot_test(int argc, char *argv[])
 	}
 
 	while (write_size) {
-		tmp = write(fd, buf, write_size);
+		int tmp = write(fd, buf, write_size);
 		if (tmp < 0) {
 			perror("write");
 			goto err_open;
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-12  5:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12  5:50 [PATCH] ARM: at91: boot_test_cmd: Fix compiler warning Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox