[PATCH] i2c: designware: fix error message formatting

[PATCH] i2c: designware: fix error message formatting

[Ahmad Fatoum]

Some error messages lack a trailing new line. One dev_dbg uses the i2c
adapter's device_d as domain, before it was allocated. Fix this.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/i2c/busses/i2c-designware.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware.c b/drivers/i2c/busses/i2c-designware.c
index bb9a0b7c4ad4..8508fac7171f 100644
--- a/drivers/i2c/busses/i2c-designware.c
+++ b/drivers/i2c/busses/i2c-designware.c
@@ -274,7 +274,7 @@ static void i2c_dw_setup_timings(struct dw_i2c_dev *dw)
 		if (!(dw->sda_hold_time & DW_IC_SDA_HOLD_RX_MASK))
 			dw->sda_hold_time |= 1 << DW_IC_SDA_HOLD_RX_SHIFT;
 
-		dev_dbg(&dw->adapter.dev, "adjust SDA hold time.\n");
+		dev_dbg(dw->adapter.dev.parent, "adjust SDA hold time.\n");
 		writel(dw->sda_hold_time, dw->base + DW_IC_SDA_HOLD);
 	}
 }
@@ -547,9 +547,7 @@ static int i2c_dw_probe(struct device_d *pdev)
 
 	ic_comp_type_value = readl(dw->base + DW_IC_COMP_TYPE);
 	if (ic_comp_type_value != DW_IC_COMP_TYPE_VALUE) {
-		dev_err(pdev,
-			"unknown DesignWare IP block 0x%08x",
-			ic_comp_type_value);
+		dev_err(pdev, "unknown DesignWare IP block 0x%08x\n", ic_comp_type_value);
 		ret = -ENODEV;
 		goto fail;
 	}
@@ -574,7 +572,7 @@ static int i2c_dw_probe(struct device_d *pdev)
 		ic_con = DW_IC_CON_SPEED_FAST;
 		break;
 	default:
-		dev_warn(pdev, "requested bitrate (%d) is not supported."
+		dev_warn(pdev, "requested bitrate (%d) is not supported.\n"
 			 " Falling back to 100kHz", bitrate);
 	case 100000:		/* FALLTHROUGH */
 		ic_con = DW_IC_CON_SPEED_STD;
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] i2c: designware: fix error message formatting

[Sascha Hauer]

On Mon, May 31, 2021 at 09:13:04AM +0200, Ahmad Fatoum wrote:
> Some error messages lack a trailing new line. One dev_dbg uses the i2c
> adapter's device_d as domain, before it was allocated. Fix this.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/i2c/busses/i2c-designware.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox