From: Sascha Hauer <s.hauer@pengutronix.de> To: Barebox List <barebox@lists.infradead.org> Subject: [PATCH 6/7] fixup! phy: Rockchip: Add driver for usb2phy Date: Tue, 22 Jun 2021 08:47:10 +0200 [thread overview] Message-ID: <20210622064711.14058-6-s.hauer@pengutronix.de> (raw) In-Reply-To: <20210622064711.14058-1-s.hauer@pengutronix.de> --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index 5c7d6ddb72..bb1a5c747e 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -333,8 +333,7 @@ static const struct clk_ops rockchip_usb2phy_clkout_ops = { .recalc_rate = rockchip_usb2phy_clk480m_recalc_rate, }; -static int -rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy) +static int rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy) { struct device_node *node = rphy->dev->device_node; struct clk_init_data init = {}; @@ -359,7 +358,6 @@ rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy) rphy->clk480m_hw.init = &init; - /* register the clock */ rphy->clk480m = clk_register(rphy->dev, &rphy->clk480m_hw); if (IS_ERR(rphy->clk480m)) { ret = PTR_ERR(rphy->clk480m); @@ -391,16 +389,13 @@ static int rockchip_usb2phy_probe(struct device_d *dev) rphy->dev = dev; - rphy->grf_base = syscon_regmap_lookup_by_phandle(np, - "rockchip,usbgrf"); + rphy->grf_base = syscon_regmap_lookup_by_phandle(np, "rockchip,usbgrf"); if (IS_ERR(rphy->grf_base)) return PTR_ERR(rphy->grf_base); phy_cfgs = device_get_match_data(dev); - if (!phy_cfgs) { - dev_err(dev, "unable to get phy_cfgs\n"); + if (!phy_cfgs) return -EINVAL; - } iores = dev_request_mem_resource(dev, 0); if (IS_ERR(iores)) { -- 2.29.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-06-22 6:48 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-22 6:47 [PATCH 1/7] usb: ehci: Handle clocks and phys Sascha Hauer 2021-06-22 6:47 ` [PATCH 2/7] phy: Rockchip: Add driver for usb2phy Sascha Hauer 2021-06-22 6:47 ` [PATCH 3/7] phy: rockchip: Add naneng-combphy support Sascha Hauer 2021-06-22 6:47 ` [PATCH 4/7] ARM: Rockchip: rk3568: Add USB nodes Sascha Hauer 2021-06-22 6:47 ` [PATCH 5/7] ARM: Rockchip: rk3568 EVB: Add USB support Sascha Hauer 2021-06-22 6:47 ` Sascha Hauer [this message] 2021-06-22 6:54 ` [PATCH 6/7] fixup! phy: Rockchip: Add driver for usb2phy Sascha Hauer 2021-06-22 6:47 ` [PATCH 7/7] fixup! phy: rockchip: Add naneng-combphy support Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210622064711.14058-6-s.hauer@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=barebox@lists.infradead.org \ --subject='Re: [PATCH 6/7] fixup'\!' phy: Rockchip: Add driver for usb2phy' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox