mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: lgo@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 3/4] input: imx-keypad: remove now-duplicate debug messages
Date: Tue,  2 Apr 2024 15:50:34 +0200	[thread overview]
Message-ID: <20240402135035.3700601-4-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20240402135035.3700601-1-a.fatoum@pengutronix.de>

With the recent addition of CONFIG_EVENT_EVBUG, the debug messages in
both i.MX keypad driver adds no extra value, so remove it.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/input/imx_keypad.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/input/imx_keypad.c b/drivers/input/imx_keypad.c
index 2c003905a7d9..e57a884630aa 100644
--- a/drivers/input/imx_keypad.c
+++ b/drivers/input/imx_keypad.c
@@ -72,7 +72,6 @@
 struct imx_keypad {
 	struct input_device input;
 	struct clk *clk;
-	struct device *dev;
 	void __iomem *mmio_base;
 
 	struct poller_struct poller;
@@ -199,10 +198,6 @@ static void imx_keypad_fire_events(struct imx_keypad *keypad,
 
 			input_report_key_event(&keypad->input, keypad->keycodes[code],
 					       matrix_volatile_state[col] & (1 << row));
-
-			dev_dbg(keypad->dev, "Event code: %d, val: %d",
-				keypad->keycodes[code],
-				matrix_volatile_state[col] & (1 << row));
 		}
 	}
 }
@@ -367,7 +362,6 @@ static int __init imx_keypad_probe(struct device *dev)
 
 	keypad = xzalloc(sizeof(struct imx_keypad));
 
-	keypad->dev = dev;
 	iores = dev_request_mem_resource(dev, 0);
 	if (IS_ERR(iores))
 		return PTR_ERR(iores);
-- 
2.39.2




  parent reply	other threads:[~2024-04-02 13:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 13:50 [PATCH 0/4] input: add CONFIG_INPUT_EVBUG debug option Ahmad Fatoum
2024-04-02 13:50 ` [PATCH 1/4] input: record parent device at registration time Ahmad Fatoum
2024-04-02 13:50 ` [PATCH 2/4] input: add CONFIG_INPUT_EVBUG debug option Ahmad Fatoum
2024-04-02 13:50 ` Ahmad Fatoum [this message]
2024-04-02 14:06   ` [PATCH 3/4] input: imx-keypad: remove now-duplicate debug messages Ahmad Fatoum
2024-04-03 11:40     ` Sascha Hauer
2024-04-02 13:50 ` [PATCH 4/4] input: gpio-keys: drop now-superfluous struct gpio_keys::dev Ahmad Fatoum
2024-04-03 11:39 ` [PATCH 0/4] input: add CONFIG_INPUT_EVBUG debug option Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402135035.3700601-4-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=lgo@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox