Re: [PATCH 3/4] input: imx-keypad: remove now-duplicate debug messages

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 02.04.24 15:50, Ahmad Fatoum wrote:
> With the recent addition of CONFIG_EVENT_EVBUG, the debug messages in

s/CONFIG_INPUT_EVBUG/CONFIG_EVENT_EVBUG/

Please let me know if I should resend.

> both i.MX keypad driver adds no extra value, so remove it.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/input/imx_keypad.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/input/imx_keypad.c b/drivers/input/imx_keypad.c
> index 2c003905a7d9..e57a884630aa 100644
> --- a/drivers/input/imx_keypad.c
> +++ b/drivers/input/imx_keypad.c
> @@ -72,7 +72,6 @@
>  struct imx_keypad {
>  	struct input_device input;
>  	struct clk *clk;
> -	struct device *dev;
>  	void __iomem *mmio_base;
>  
>  	struct poller_struct poller;
> @@ -199,10 +198,6 @@ static void imx_keypad_fire_events(struct imx_keypad *keypad,
>  
>  			input_report_key_event(&keypad->input, keypad->keycodes[code],
>  					       matrix_volatile_state[col] & (1 << row));
> -
> -			dev_dbg(keypad->dev, "Event code: %d, val: %d",
> -				keypad->keycodes[code],
> -				matrix_volatile_state[col] & (1 << row));
>  		}
>  	}
>  }
> @@ -367,7 +362,6 @@ static int __init imx_keypad_probe(struct device *dev)
>  
>  	keypad = xzalloc(sizeof(struct imx_keypad));
>  
> -	keypad->dev = dev;
>  	iores = dev_request_mem_resource(dev, 0);
>  	if (IS_ERR(iores))
>  		return PTR_ERR(iores);

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |