mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Cc: anis chali <chalianis1@gmail.com>, Sascha Hauer <sascha@saschahauer.de>
Subject: [PATCH v2 0/3] USB: dwc2: Fix handling NAK
Date: Tue, 02 Jun 2026 11:29:19 +0200	[thread overview]
Message-ID: <20260602-usb-dwc2-usb-c-stick-v2-0-0e02782c7e32@pengutronix.de> (raw)

A NAK should return -EAGAIN to let the retry logic work. This showed up
on a Samsung USB-C memory stick which otherwise was recognized, but
couldn't be initialized.

The v2 now adddresses Anis' log spamming problems. The solution here is
to just silence the error message by turning it into dev_dbg. The
message says "Timeout on bulk endpoint" which is normal and expected
behaviour. The usbnet driver expects bulk messages to timeout when
no RX data is available.

I do not have a Rpi4 CM to reproduce Anis problems, but I have seen the
same on a Rpi3B. With this series USB memory sticks now work on the
Rpi3B, hopefully on the Rpi4 CM as well.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
Changes in v2:
- Address Anis Chalis log spam problems
- Link to v1: https://lore.barebox.org/20260420-usb-dwc2-usb-c-stick-v1-0-c86f733f24f8@pengutronix.de

---
Sascha Hauer (3):
      usb: dwc2: Do not print error messages when URBs are nacked
      usb: dwc2: handle NAK when CHHLTD does not fire
      usb: dwc2: fix data toggle reset direction on ClearFeature(ENDPOINT_HALT)

 drivers/usb/dwc2/host.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
---
base-commit: 651343da8af78d134d7ead4d2b36095d7ddc2d8f
change-id: 20260420-usb-dwc2-usb-c-stick-ea31c736477c

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




             reply	other threads:[~2026-06-02  9:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02  9:29 Sascha Hauer [this message]
2026-06-02  9:29 ` [PATCH v2 1/3] usb: dwc2: Do not print error messages when URBs are nacked Sascha Hauer
2026-06-02  9:29 ` [PATCH v2 2/3] usb: dwc2: handle NAK when CHHLTD does not fire Sascha Hauer
2026-06-02  9:29 ` [PATCH v2 3/3] usb: dwc2: fix data toggle reset direction on ClearFeature(ENDPOINT_HALT) Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260602-usb-dwc2-usb-c-stick-v2-0-0e02782c7e32@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=chalianis1@gmail.com \
    --cc=sascha@saschahauer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox