From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Cc: anis chali <chalianis1@gmail.com>
Subject: [PATCH v2 1/3] usb: dwc2: Do not print error messages when URBs are nacked
Date: Tue, 02 Jun 2026 11:29:20 +0200 [thread overview]
Message-ID: <20260602-usb-dwc2-usb-c-stick-v2-1-0e02782c7e32@pengutronix.de> (raw)
In-Reply-To: <20260602-usb-dwc2-usb-c-stick-v2-0-0e02782c7e32@pengutronix.de>
It's a normal usecase that a USB bulk transfer is nacked, so do not
print an error message in this case. The usbnet driver polls the
availability of RX frames with bulk transfers with short timeouts.
When it's nacked it just means that currently no RX data is available.
Currently wait_for_chhltd() returns -ETIMEDOUT when a transfer is
nacked, so the message is not printed. This however changes with
the next patch, so silence the error message now to avoid log spam
with the next patch.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/usb/dwc2/host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/host.c b/drivers/usb/dwc2/host.c
index 93994f0be3..eede21c692 100644
--- a/drivers/usb/dwc2/host.c
+++ b/drivers/usb/dwc2/host.c
@@ -435,7 +435,7 @@ static int dwc2_submit_bulk_msg(struct usb_device *udev, unsigned long pipe,
buffer, len);
} while (ret == -EAGAIN && !is_timeout(start, timeout * MSECOND));
if (ret == -EAGAIN) {
- dwc2_err(dwc2, "Timeout on bulk endpoint\n");
+ dwc2_dbg(dwc2, "Timeout on bulk endpoint\n");
ret = -ETIMEDOUT;
}
--
2.47.3
next prev parent reply other threads:[~2026-06-02 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 9:29 [PATCH v2 0/3] USB: dwc2: Fix handling NAK Sascha Hauer
2026-06-02 9:29 ` Sascha Hauer [this message]
2026-06-02 9:29 ` [PATCH v2 2/3] usb: dwc2: handle NAK when CHHLTD does not fire Sascha Hauer
2026-06-02 9:29 ` [PATCH v2 3/3] usb: dwc2: fix data toggle reset direction on ClearFeature(ENDPOINT_HALT) Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602-usb-dwc2-usb-c-stick-v2-1-0e02782c7e32@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=chalianis1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox