mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] base: driver: fix double removal of child devices
@ 2021-09-13  8:29 Ahmad Fatoum
  2021-09-13 10:08 ` Jules Maselbas
  0 siblings, 1 reply; 3+ messages in thread
From: Ahmad Fatoum @ 2021-09-13  8:29 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Child devices like an ext4 file system on a partition may be removed
twice: Once because they're in the active devices list and then once
more, because unregister_device is called for the children of its parent.

As struct bus_type::remove clears association of a driver with its
device, we can set struct device_d::driver to NULL. unregister_device
will then skip the second dev->bus->remove.

Fixes: 29f1c211d86c ("fs: don't free device in remove callback")
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/base/driver.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index 0e04ef36868d..0fedb30161b4 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -512,7 +512,10 @@ static void devices_shutdown(void)
 
 	list_for_each_entry(dev, &active, active) {
 		if (dev->bus->remove)
+		if (dev->bus->remove) {
 			dev->bus->remove(dev);
+			dev->driver = NULL;
+		}
 	}
 }
 devshutdown_exitcall(devices_shutdown);
-- 
2.33.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-13 10:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13  8:29 [PATCH master] base: driver: fix double removal of child devices Ahmad Fatoum
2021-09-13 10:08 ` Jules Maselbas
2021-09-13 10:18   ` Ahmad Fatoum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox