mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] clk: starfive-jh7100: Fix duplicate numbers
Date: Thu, 24 Jun 2021 21:05:20 +0200	[thread overview]
Message-ID: <c20c131f-89d9-a3c0-1d91-9d3de583236c@pengutronix.de> (raw)
In-Reply-To: <20210624150931.891123-1-geert@linux-m68k.org>

Hello Geert,

On 24.06.21 17:09, Geert Uytterhoeven wrote:
> Fixes: 6f92e74e5b94d8e6 ("clk: add initial StarFive clock support")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Completely untested.

Thanks for catching!
Gave it a run and it[1] still boots to shell:

Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

[1]: https://github.com/a3f/barebox/tree/beaglev

> 
>  include/dt-bindings/clock/starfive-jh7100.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/starfive-jh7100.h b/include/dt-bindings/clock/starfive-jh7100.h
> index 9ad5e7f9bfd5f655..2512bb810ec45c8b 100644
> --- a/include/dt-bindings/clock/starfive-jh7100.h
> +++ b/include/dt-bindings/clock/starfive-jh7100.h
> @@ -42,9 +42,9 @@
>  #define CLK_U74_CORE1		33
>  #define CLK_U74_AXI		34
>  #define CLK_U74RTC_TOGGLE	35
> -#define CLK_SGDMA2P_AXI		35
> +#define CLK_SGDMA2P_AXI		36
>  #define CLK_DMA2PNOC_AXI	37
> -#define CLK_SGDMA2P_AHB		37
> +#define CLK_SGDMA2P_AHB		38
>  #define CLK_DLA_BUS		39
>  #define CLK_DLA_AXI		40
>  #define CLK_DLANOC_AXI		41
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-06-24 19:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 15:09 Geert Uytterhoeven
2021-06-24 19:05 ` Ahmad Fatoum [this message]
2021-06-25  7:40 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c20c131f-89d9-a3c0-1d91-9d3de583236c@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=geert@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox