* [PATCH] clk: starfive-jh7100: Fix duplicate numbers
@ 2021-06-24 15:09 Geert Uytterhoeven
2021-06-24 19:05 ` Ahmad Fatoum
2021-06-25 7:40 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-06-24 15:09 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox, Geert Uytterhoeven
Fixes: 6f92e74e5b94d8e6 ("clk: add initial StarFive clock support")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Completely untested.
include/dt-bindings/clock/starfive-jh7100.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/dt-bindings/clock/starfive-jh7100.h b/include/dt-bindings/clock/starfive-jh7100.h
index 9ad5e7f9bfd5f655..2512bb810ec45c8b 100644
--- a/include/dt-bindings/clock/starfive-jh7100.h
+++ b/include/dt-bindings/clock/starfive-jh7100.h
@@ -42,9 +42,9 @@
#define CLK_U74_CORE1 33
#define CLK_U74_AXI 34
#define CLK_U74RTC_TOGGLE 35
-#define CLK_SGDMA2P_AXI 35
+#define CLK_SGDMA2P_AXI 36
#define CLK_DMA2PNOC_AXI 37
-#define CLK_SGDMA2P_AHB 37
+#define CLK_SGDMA2P_AHB 38
#define CLK_DLA_BUS 39
#define CLK_DLA_AXI 40
#define CLK_DLANOC_AXI 41
--
2.25.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: starfive-jh7100: Fix duplicate numbers
2021-06-24 15:09 [PATCH] clk: starfive-jh7100: Fix duplicate numbers Geert Uytterhoeven
@ 2021-06-24 19:05 ` Ahmad Fatoum
2021-06-25 7:40 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2021-06-24 19:05 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: barebox
Hello Geert,
On 24.06.21 17:09, Geert Uytterhoeven wrote:
> Fixes: 6f92e74e5b94d8e6 ("clk: add initial StarFive clock support")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Completely untested.
Thanks for catching!
Gave it a run and it[1] still boots to shell:
Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
[1]: https://github.com/a3f/barebox/tree/beaglev
>
> include/dt-bindings/clock/starfive-jh7100.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/dt-bindings/clock/starfive-jh7100.h b/include/dt-bindings/clock/starfive-jh7100.h
> index 9ad5e7f9bfd5f655..2512bb810ec45c8b 100644
> --- a/include/dt-bindings/clock/starfive-jh7100.h
> +++ b/include/dt-bindings/clock/starfive-jh7100.h
> @@ -42,9 +42,9 @@
> #define CLK_U74_CORE1 33
> #define CLK_U74_AXI 34
> #define CLK_U74RTC_TOGGLE 35
> -#define CLK_SGDMA2P_AXI 35
> +#define CLK_SGDMA2P_AXI 36
> #define CLK_DMA2PNOC_AXI 37
> -#define CLK_SGDMA2P_AHB 37
> +#define CLK_SGDMA2P_AHB 38
> #define CLK_DLA_BUS 39
> #define CLK_DLA_AXI 40
> #define CLK_DLANOC_AXI 41
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: starfive-jh7100: Fix duplicate numbers
2021-06-24 15:09 [PATCH] clk: starfive-jh7100: Fix duplicate numbers Geert Uytterhoeven
2021-06-24 19:05 ` Ahmad Fatoum
@ 2021-06-25 7:40 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2021-06-25 7:40 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Ahmad Fatoum, barebox
On Thu, Jun 24, 2021 at 05:09:31PM +0200, Geert Uytterhoeven wrote:
> Fixes: 6f92e74e5b94d8e6 ("clk: add initial StarFive clock support")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Completely untested.
>
> include/dt-bindings/clock/starfive-jh7100.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/include/dt-bindings/clock/starfive-jh7100.h b/include/dt-bindings/clock/starfive-jh7100.h
> index 9ad5e7f9bfd5f655..2512bb810ec45c8b 100644
> --- a/include/dt-bindings/clock/starfive-jh7100.h
> +++ b/include/dt-bindings/clock/starfive-jh7100.h
> @@ -42,9 +42,9 @@
> #define CLK_U74_CORE1 33
> #define CLK_U74_AXI 34
> #define CLK_U74RTC_TOGGLE 35
> -#define CLK_SGDMA2P_AXI 35
> +#define CLK_SGDMA2P_AXI 36
> #define CLK_DMA2PNOC_AXI 37
> -#define CLK_SGDMA2P_AHB 37
> +#define CLK_SGDMA2P_AHB 38
> #define CLK_DLA_BUS 39
> #define CLK_DLA_AXI 40
> #define CLK_DLANOC_AXI 41
> --
> 2.25.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-25 8:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 15:09 [PATCH] clk: starfive-jh7100: Fix duplicate numbers Geert Uytterhoeven
2021-06-24 19:05 ` Ahmad Fatoum
2021-06-25 7:40 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox