From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Sascha Hauer <s.hauer@pengutronix.de>, Barebox List <barebox@lists.infradead.org> Subject: Re: [PATCH 1/2] net: designware: eqos: reset phy Date: Mon, 7 Jun 2021 17:59:02 +0200 [thread overview] Message-ID: <e787566e-33cc-0b9e-73e3-74ab23812646@pengutronix.de> (raw) In-Reply-To: <20210607141057.23255-1-s.hauer@pengutronix.de> Hello Sascha, On 07.06.21 16:10, Sascha Hauer wrote: > The designware eqos DT binding has support for specifying reset GPIOs. > Add support for them. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > drivers/net/designware_eqos.c | 33 +++++++++++++++++++++++++++++++++ > drivers/of/of_gpio.c | 7 +++++++ > 2 files changed, 40 insertions(+) > > diff --git a/drivers/net/designware_eqos.c b/drivers/net/designware_eqos.c > index d2baaeaf63..0321024169 100644 > --- a/drivers/net/designware_eqos.c > +++ b/drivers/net/designware_eqos.c > @@ -8,9 +8,11 @@ > > #include <common.h> > #include <init.h> > +#include <gpio.h> > #include <dma.h> > #include <net.h> > #include <of_net.h> > +#include <of_gpio.h> > #include <linux/iopoll.h> > #include <linux/time.h> > #include <linux/sizes.h> > @@ -189,6 +191,33 @@ struct eqos_desc { > > #define MII_BUSY (1 << 0) > > +static int eqos_phy_reset(struct device_d *dev, struct eqos *eqos) > +{ > + int phy_reset; > + int ret; > + u32 delays[3] = { 0, 0, 0 }; > + > + phy_reset = of_get_named_gpio(dev->device_node, "snps,reset-gpio", 0); > + > + if (!gpio_is_valid(phy_reset)) > + return 0; Whitespace is wrong. > + > + ret = gpio_request(phy_reset, "phy-reset"); > + if (ret) > + return ret; Can you use gpiod_get instead? This would reduce the boilerplate here. > + > + of_property_read_u32_array(dev->device_node, > + "snps,reset-delays-us", > + delays, ARRAY_SIZE(delays)); > + Looks strange to read out a delay and not act on it. I'd prefer waiting delays[0] here. > + gpio_direction_active(phy_reset, 0); This always sets logical zero, because gpio_request above doesn't accept a flag telling it otherwise. You'll need of_get_named_gpio_flags here, at which point, you'll have basically open-coded gpiod_get(), so you could use that. > + udelay(delays[1]); Linux rounds up to 1 msec granularity here. We should do likewise. > + gpio_set_active(phy_reset, 1); Nitpick: true/false. > + udelay(delays[2]); > + > + return 0; > +} > + > static int eqos_mdio_wait_idle(struct eqos *eqos) > { > u32 idle; > @@ -843,6 +872,10 @@ int eqos_probe(struct device_d *dev, const struct eqos_ops *ops, void *priv) > if (ret) > return ret; > > + ret = eqos_phy_reset(dev, eqos); > + if (ret) > + return ret; > + > ret = mdiobus_register(miibus); > if (ret) > return ret; > diff --git a/drivers/of/of_gpio.c b/drivers/of/of_gpio.c > index 7cbeeaf69e..e1cafdc848 100644 > --- a/drivers/of/of_gpio.c > +++ b/drivers/of/of_gpio.c > @@ -35,6 +35,13 @@ static void of_gpio_flags_quirks(struct device_node *np, > if (active_low) > *flags |= OF_GPIO_ACTIVE_LOW; > } > + > + /* Legacy handling of stmmac's active-low PHY reset line */ > + if (IS_ENABLED(CONFIG_DRIVER_NET_DESIGNWARE_EQOS) && > + !strcmp(propname, "snps,reset-gpio") && > + of_property_read_bool(np, "snps,reset-active-low")) > + *flags |= OF_GPIO_ACTIVE_LOW; > + > } > > /** > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-06-07 16:00 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-07 14:10 Sascha Hauer 2021-06-07 14:10 ` [PATCH 2/2] net: eqos: Rockchip support Sascha Hauer 2021-06-07 16:05 ` Ahmad Fatoum 2021-06-07 15:59 ` Ahmad Fatoum [this message] 2021-06-07 22:22 ` [PATCH 1/2] net: designware: eqos: reset phy Sascha Hauer 2021-06-08 7:31 ` Ahmad Fatoum 2021-06-08 8:58 ` Sascha Hauer 2021-06-09 8:04 ` Ahmad Fatoum
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e787566e-33cc-0b9e-73e3-74ab23812646@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=s.hauer@pengutronix.de \ --subject='Re: [PATCH 1/2] net: designware: eqos: reset phy' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox