mailarchive of the pengutronix oss-tools mailing list
 help / color / mirror / Atom feed
* [OSS-Tools] [PATCH] libdt: enumerate amba bus as well
@ 2020-10-08 15:09 Ahmad Fatoum
  2021-02-10  9:31 ` Jan Lübbe
  0 siblings, 1 reply; 3+ messages in thread
From: Ahmad Fatoum @ 2020-10-08 15:09 UTC (permalink / raw)
  To: oss-tools; +Cc: Xogium, Jookia

The STM32MP1 probes the SD/MMC host controller over amba, not
the platform bus as most other ARM systems. Enumerate amba as well,
so we can use barebox-state on that SoC.

Reported-by: Jookia <contact@jookia.org>
Tested-by: Xogium <contact@xogium.me>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 src/libdt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/libdt.c b/src/libdt.c
index 01f0a6941aa2..342313f8aed7 100644
--- a/src/libdt.c
+++ b/src/libdt.c
@@ -2057,6 +2057,7 @@ static void of_scan_udev_devices(void)
 	udev_enumerate_add_match_subsystem(enumerate, "i2c");
 	udev_enumerate_add_match_subsystem(enumerate, "spi");
 	udev_enumerate_add_match_subsystem(enumerate, "mtd");
+	udev_enumerate_add_match_subsystem(enumerate, "amba");
 	udev_enumerate_scan_devices(enumerate);
 	devices = udev_enumerate_get_list_entry(enumerate);
 
-- 
2.28.0


_______________________________________________
OSS-Tools mailing list
OSS-Tools@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [OSS-Tools] [PATCH] libdt: enumerate amba bus as well
  2020-10-08 15:09 [OSS-Tools] [PATCH] libdt: enumerate amba bus as well Ahmad Fatoum
@ 2021-02-10  9:31 ` Jan Lübbe
  2021-03-16 14:19   ` Roland Hieber
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Lübbe @ 2021-02-10  9:31 UTC (permalink / raw)
  To: Ahmad Fatoum, oss-tools

On Thu, 2020-10-08 at 17:09 +0200, Ahmad Fatoum wrote:
> The STM32MP1 probes the SD/MMC host controller over amba, not
> the platform bus as most other ARM systems. Enumerate amba as well,
> so we can use barebox-state on that SoC.
> 
> Reported-by: Jookia <contact@jookia.org>
> Tested-by: Xogium <contact@xogium.me>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Works on my STM32MP1DK2.

Tested-by: Jan Luebbe <jlu@pengutronix.de>

> ---
>  src/libdt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libdt.c b/src/libdt.c
> index 01f0a6941aa2..342313f8aed7 100644
> --- a/src/libdt.c
> +++ b/src/libdt.c
> @@ -2057,6 +2057,7 @@ static void of_scan_udev_devices(void)
>  	udev_enumerate_add_match_subsystem(enumerate, "i2c");
>  	udev_enumerate_add_match_subsystem(enumerate, "spi");
>  	udev_enumerate_add_match_subsystem(enumerate, "mtd");
> +	udev_enumerate_add_match_subsystem(enumerate, "amba");
>  	udev_enumerate_scan_devices(enumerate);
>  	devices = udev_enumerate_get_list_entry(enumerate);
>  
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


_______________________________________________
OSS-Tools mailing list
OSS-Tools@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [OSS-Tools] [PATCH] libdt: enumerate amba bus as well
  2021-02-10  9:31 ` Jan Lübbe
@ 2021-03-16 14:19   ` Roland Hieber
  0 siblings, 0 replies; 3+ messages in thread
From: Roland Hieber @ 2021-03-16 14:19 UTC (permalink / raw)
  To: Jan Lübbe; +Cc: oss-tools

On Wed, Feb 10, 2021 at 10:31:44AM +0100, Jan Lübbe wrote:
> On Thu, 2020-10-08 at 17:09 +0200, Ahmad Fatoum wrote:
> > The STM32MP1 probes the SD/MMC host controller over amba, not
> > the platform bus as most other ARM systems. Enumerate amba as well,
> > so we can use barebox-state on that SoC.
> > 
> > Reported-by: Jookia <contact@jookia.org>
> > Tested-by: Xogium <contact@xogium.me>
> > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> 
> Works on my STM32MP1DK2.
> 
> Tested-by: Jan Luebbe <jlu@pengutronix.de>

Thanks, applied.

 - Roland

> 
> > ---
> >  src/libdt.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/libdt.c b/src/libdt.c
> > index 01f0a6941aa2..342313f8aed7 100644
> > --- a/src/libdt.c
> > +++ b/src/libdt.c
> > @@ -2057,6 +2057,7 @@ static void of_scan_udev_devices(void)
> >  	udev_enumerate_add_match_subsystem(enumerate, "i2c");
> >  	udev_enumerate_add_match_subsystem(enumerate, "spi");
> >  	udev_enumerate_add_match_subsystem(enumerate, "mtd");
> > +	udev_enumerate_add_match_subsystem(enumerate, "amba");
> >  	udev_enumerate_scan_devices(enumerate);
> >  	devices = udev_enumerate_get_list_entry(enumerate);
> >  
> > 
> > 
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 
> _______________________________________________
> OSS-Tools mailing list
> OSS-Tools@pengutronix.de

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
OSS-Tools mailing list
OSS-Tools@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-16 14:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 15:09 [OSS-Tools] [PATCH] libdt: enumerate amba bus as well Ahmad Fatoum
2021-02-10  9:31 ` Jan Lübbe
2021-03-16 14:19   ` Roland Hieber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox