mailarchive of the pengutronix oss-tools mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>
Cc: oss-tools@pengutronix.de
Subject: Re: [OSS-Tools] [PATCH dt-utils 3/4] treewide: add SPDX identifier to files with Zlib license
Date: Tue, 30 Mar 2021 14:55:33 +0200	[thread overview]
Message-ID: <20210330125533.75xdis36flv2dxbu@pengutronix.de> (raw)
In-Reply-To: <20210326210647.8648-3-rhi@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 1686 bytes --]

On Fri, Mar 26, 2021 at 10:06:46PM +0100, Roland Hieber wrote:
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  src/crc32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/crc32.c b/src/crc32.c
> index 8d4dddcf6129..6d534c996050 100644
> --- a/src/crc32.c
> +++ b/src/crc32.c
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: Zlib */
>  /*
>   * This file is derived from crc32.c from the zlib-1.1.3 distribution
>   * by Jean-loup Gailly and Mark Adler.
> @@ -5,7 +6,6 @@
>  
>  /* crc32.c -- compute the CRC-32 of a data stream
>   * Copyright (C) 1995-1998 Mark Adler
> - * For conditions of distribution and use, see copyright notice in zlib.h
>   */

Interesting hunk separation. I wonder if this is worth to be reported
to the git list because

diff --git a/src/crc32.c b/src/crc32.c
index 8d4dddcf6129..6d534c996050 100644
--- a/src/crc32.c
+++ b/src/crc32.c
@@ -1,11 +1,11 @@
+/* SPDX-License-Identifier: Zlib */
 /*
  * This file is derived from crc32.c from the zlib-1.1.3 distribution
  * by Jean-loup Gailly and Mark Adler.
  */
 
 /* crc32.c -- compute the CRC-32 of a data stream
  * Copyright (C) 1995-1998 Mark Adler
- * For conditions of distribution and use, see copyright notice in zlib.h
  */
 
 #include <stdint.h>

should be equivalent and isn't any longer. Or is it only me who
considers this obviously better?

Other than that:

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 96 bytes --]

_______________________________________________
OSS-Tools mailing list
OSS-Tools@pengutronix.de

  reply	other threads:[~2021-03-30 12:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 21:06 [OSS-Tools] [PATCH dt-utils 1/4] treewide: add SPDX identifiers to files with GPL-2.0-or-later license Roland Hieber
2021-03-26 21:06 ` [OSS-Tools] [PATCH dt-utils 2/4] treewide: add SPDX identifiers to files with GPL-2.0-only license Roland Hieber
2021-03-30 12:50   ` Uwe Kleine-König
2021-03-26 21:06 ` [OSS-Tools] [PATCH dt-utils 3/4] treewide: add SPDX identifier to files with Zlib license Roland Hieber
2021-03-30 12:55   ` Uwe Kleine-König [this message]
2021-03-26 21:06 ` [OSS-Tools] [PATCH dt-utils 4/4] treewide: add SPDX identifiers to files without license Roland Hieber
2021-03-30 11:08 ` [OSS-Tools] [PATCH dt-utils 1/4] treewide: add SPDX identifiers to files with GPL-2.0-or-later license Roland Hieber
2021-03-30 11:22   ` Ahmad Fatoum
2021-03-30 13:30     ` Uwe Kleine-König
2021-03-30 13:50       ` Ahmad Fatoum
2021-03-30 14:00         ` Uwe Kleine-König
2021-03-30 14:04           ` Ahmad Fatoum
2021-03-30 15:53         ` Roland Hieber
2021-03-30 17:31           ` Ahmad Fatoum
2021-03-31 10:03             ` Roland Hieber
2021-03-31 10:10               ` Roland Hieber
2021-03-30 12:49 ` Uwe Kleine-König
2023-08-01 10:10 ` Roland Hieber
2023-08-01 10:12   ` Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210330125533.75xdis36flv2dxbu@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=oss-tools@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox