mailarchive of the pengutronix oss-tools mailing list
 help / color / mirror / Atom feed
* [OSS-Tools] [PATCH] plugin: remove sync variable
@ 2023-01-05 16:05 Michael Tretter
  0 siblings, 0 replies; only message in thread
From: Michael Tretter @ 2023-01-05 16:05 UTC (permalink / raw)
  To: oss-tools; +Cc: mtr

The sync variable allows to disable sync on the GStreamer sink element.
Currently it is set to true and never changed.

With glibc 2.36, the variable conflicts with the definition of the `void
sync()` symbol defined in /usr/include/unistd.h, which is a POSIX
standard function.

Having this variable is doubtful by itself, but conflicting with a POSIX
declaration is bad.

Signed-off-by: Michael Tretter <>
 plugin/gstplayer.cpp | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/plugin/gstplayer.cpp b/plugin/gstplayer.cpp
index c0b12df08d40..ebb14ed2f7c4 100644
--- a/plugin/gstplayer.cpp
+++ b/plugin/gstplayer.cpp
@@ -10,8 +10,6 @@
 Q_LOGGING_CATEGORY(lcGstPlayer, "gst.player", QtWarningMsg)
-static bool sync = true;
 QtGstPlayer::QtGstPlayer() :
@@ -449,9 +447,6 @@ void QtGstPlayer::updatePipeline()
 		g_signal_connect(m_pipeline, "deep-notify",
 				G_CALLBACK(gst_object_default_deep_notify), NULL);
-	if (!sync)
-		g_object_set(G_OBJECT(sinkBin), "sync", FALSE, NULL);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-05 16:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-05 16:05 [OSS-Tools] [PATCH] plugin: remove sync variable Michael Tretter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox