mailarchive of the pengutronix oss-tools mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: oss-tools@pengutronix.de, graphics@pengutronix.de
Subject: [OSS-Tools] [PATCH 3/3] plugin: remove sync variable
Date: Mon, 13 Feb 2023 15:57:23 +0100	[thread overview]
Message-ID: <20230213145723.4065393-3-m.felsch@pengutronix.de> (raw)
In-Reply-To: <20230213145723.4065393-1-m.felsch@pengutronix.de>

From: Michael Tretter <m.tretter@pengutronix.de>

The sync variable allows to disable sync on the GStreamer sink element.
Currently it is set to true and never changed.

With glibc 2.36, the variable conflicts with the definition of the `void
sync()` symbol defined in /usr/include/unistd.h, which is a POSIX
standard function.

Having this variable is doubtful by itself, but conflicting with a POSIX
declaration is bad.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 plugin/gstplayer.cpp | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/plugin/gstplayer.cpp b/plugin/gstplayer.cpp
index df2c0c9..7679c50 100644
--- a/plugin/gstplayer.cpp
+++ b/plugin/gstplayer.cpp
@@ -10,8 +10,6 @@
 
 Q_LOGGING_CATEGORY(lcGstPlayer, "gst.player", QtWarningMsg)
 
-static bool sync = true;
-
 QtGstPlayer::QtGstPlayer() :
 		m_pipeline(NULL),
 		m_sink(NULL),
@@ -451,9 +449,6 @@ void QtGstPlayer::updatePipeline()
 		g_signal_connect(m_pipeline, "deep-notify",
 				G_CALLBACK(gst_object_default_deep_notify), NULL);
 
-	if (!sync)
-		g_object_set(G_OBJECT(sinkBin), "sync", FALSE, NULL);
-
 	setState(m_state);
 }
 
-- 
2.30.2




  parent reply	other threads:[~2023-02-13 14:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 14:57 [OSS-Tools] [PATCH 1/3] gstplayer: make use of playbin3 Marco Felsch
2023-02-13 14:57 ` [OSS-Tools] [PATCH 2/3] set pipeline latency and add some max-lateness slack Marco Felsch
2023-02-13 14:57 ` Marco Felsch [this message]
2023-02-13 15:04 ` [OSS-Tools] [PATCH 1/3] gstplayer: make use of playbin3 Michael Olbrich
2023-02-13 15:08   ` Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213145723.4065393-3-m.felsch@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=graphics@pengutronix.de \
    --cc=oss-tools@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox