Re: [OSS-Tools] [PATCH 1/3] gstplayer: make use of playbin3

[Michael Olbrich <m.olbrich@pengutronix.de>]

All 3 patches look good. Please push.

mol

On Mon, Feb 13, 2023 at 03:57:21PM +0100, Marco Felsch wrote:
> Replace the 'playbin' by the more recent 'playbin3' element.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  plugin/gstplayer.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/plugin/gstplayer.cpp b/plugin/gstplayer.cpp
> index c0b12df..909843b 100644
> --- a/plugin/gstplayer.cpp
> +++ b/plugin/gstplayer.cpp
> @@ -408,14 +408,14 @@ void QtGstPlayer::updatePipeline()
>  	QString prefix = "gst-pipeline:";
>  	QString source = m_source;
>  
> -	/* default pipeline (playbin) */
> +	/* default pipeline (playbin3) */
>  	if (source.indexOf(prefix) != 0) {
> -		m_pipeline = gst_element_factory_make("playbin", NULL);
> +		m_pipeline = gst_element_factory_make("playbin3", NULL);
>  
>  		g_signal_connect(m_pipeline, "element-setup", G_CALLBACK(setup_element_callback), this);
>  
>  		if (!m_pipeline) {
> -			qCWarning(lcGstPlayer, "Failed to create playbin element, \
> +			qCWarning(lcGstPlayer, "Failed to create playbin3 element, \
>  				  is the GStreamer playback plugin installed?");
>  			return;
>  		}
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |