From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: Barebox List <barebox@lists.infradead.org> Subject: Re: [PATCH] mci: dw_mmc: set dma mask to work correctly on 64bit platforms Date: Fri, 11 Jun 2021 12:40:12 +0200 [thread overview] Message-ID: <0c1b20e7-f829-fe21-ef0c-62b1bf246606@pengutronix.de> (raw) In-Reply-To: <20210611100208.GD22904@pengutronix.de> Hi, On 11.06.21 12:02, Sascha Hauer wrote: > On Fri, Jun 11, 2021 at 10:23:25AM +0200, Ahmad Fatoum wrote: >> Hello Sascha, >> >> On 10.06.21 15:10, Sascha Hauer wrote: >>> The variant we support currently can only do 32bit DMA. Adjust dma mask >>> accordingly. Also use dma_map_single() rather than dma_sync_single() to >>> actually get errors when the mapping fails. >>> >>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> >> >> Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> >> >> On a StarFive JH7100 (64-bit CPU, 32-bit MMC controller, non-1:1 mapping for >> coherent DMA). >> >>> host->idmac = dma_alloc_coherent(sizeof(*host->idmac) * DW_MMC_NUM_IDMACS, >>> - DMA_ADDRESS_BROKEN); >>> + &host->idmac_dma); >>> + if (!host->idmac) >> >> That works for Linux, but not for barebox: barebox dma_alloc_coherent doesn't have >> >> a dev parameter, so it can't check for dma_mapping_error() internally. > > Yeah, I know. I have that on my mental todo list and hoped nobody would > realize. Tss. tss. ;) > Adding a dev parameter to dma_alloc_coherent() is one thing. With that > we can check for errors. The next step of course would be to allocate > memory in the allowed area, not only to complain. What you can do for now is checking for dma_mapping_error here and abort the probe if you exceed the mask. > >> >> dma_alloc_coherent also never returns NULL in barebox, all implementations, except >> >> for kvx, abort if no memory could be allocated. >> >>> + return PTR_ERR(-ENOMEM); >> >> -ENOMEM is no pointer. > > Yes, fixed. > > Sascha > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-06-11 10:42 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-10 13:10 Sascha Hauer 2021-06-11 8:23 ` Ahmad Fatoum 2021-06-11 10:02 ` Sascha Hauer 2021-06-11 10:40 ` Ahmad Fatoum [this message] 2021-06-11 8:26 ` Ahmad Fatoum
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0c1b20e7-f829-fe21-ef0c-62b1bf246606@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=s.hauer@pengutronix.de \ --subject='Re: [PATCH] mci: dw_mmc: set dma mask to work correctly on 64bit platforms' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox