From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] mci: dw_mmc: set dma mask to work correctly on 64bit platforms
Date: Fri, 11 Jun 2021 10:26:05 +0200 [thread overview]
Message-ID: <2f23597e-855f-2424-24e7-40ca16e332ed@pengutronix.de> (raw)
In-Reply-To: <20210610131032.6645-1-s.hauer@pengutronix.de>
On 10.06.21 15:10, Sascha Hauer wrote:
> The variant we support currently can only do 32bit DMA. Adjust dma mask
> accordingly. Also use dma_map_single() rather than dma_sync_single() to
> actually get errors when the mapping fails.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/mci/dw_mmc.c | 53 ++++++++++++++++++++++++++------------------
> 1 file changed, 31 insertions(+), 22 deletions(-)
> static int dwmci_set_transfer_mode(struct dwmci_host *host,
> @@ -272,6 +271,7 @@ dwmci_cmd(struct mci_host *mci, struct mci_cmd *cmd, struct mci_data *data)
> uint64_t start;
> int ret;
> unsigned int num_bytes = 0;
> + dma_addr_t dma = 0;
>
> start = get_time_ns();
> while (1) {
> @@ -287,16 +287,20 @@ dwmci_cmd(struct mci_host *mci, struct mci_cmd *cmd, struct mci_data *data)
> dwmci_writel(host, DWMCI_RINTSTS, DWMCI_INTMSK_ALL);
>
> if (data) {
> +
stray new line
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-06-11 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 13:10 Sascha Hauer
2021-06-11 8:23 ` Ahmad Fatoum
2021-06-11 10:02 ` Sascha Hauer
2021-06-11 10:40 ` Ahmad Fatoum
2021-06-11 8:26 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f23597e-855f-2424-24e7-40ca16e332ed@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--subject='Re: [PATCH] mci: dw_mmc: set dma mask to work correctly on 64bit platforms' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox