[PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig

[PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig

[Ahmad Fatoum]

ci: musl-tools: disable KEYTOC as it depends on OpenSSL

The OpenSSL we ship in the CI container is built against glibc and so
compiling keytoc against musl in it is currently not possible.

Fix the CI breakage by disable KEYTOC, but only for the Github workflow.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Patch is not yet on master branch, so this could be simply squashed.

 .github/workflows/musl-tools.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.github/workflows/musl-tools.yml b/.github/workflows/musl-tools.yml
index 52cdd184ade3..d85328bc3f3c 100644
--- a/.github/workflows/musl-tools.yml
+++ b/.github/workflows/musl-tools.yml
@@ -34,6 +34,10 @@ jobs:
         m () { make -j$(nproc) CC=musl-gcc LD=musl-gcc HOSTCC=musl-gcc HOSTLD=musl-ld "$@"; }
 
         m ${{matrix.defconfig}}
+
+        # CI image ships OpenSSL development files only for glibc
+        scripts/config --disable KEYTOC
+
         m scripts/
 
         test -n "$(musl-ldd scripts/imx/imx-usb-loader${{matrix.suffix}} 2>/dev/null | grep musl)"
-- 
2.47.3

Re: [PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig

[Sascha Hauer]

On Wed, 05 Aug 2026 16:20:02 +0200, Ahmad Fatoum wrote:
> ci: musl-tools: disable KEYTOC as it depends on OpenSSL
> 
> The OpenSSL we ship in the CI container is built against glibc and so
> compiling keytoc against musl in it is currently not possible.
> 
> Fix the CI breakage by disable KEYTOC, but only for the Github workflow.
> 
> [...]

Applied, thanks!

[1/1] fixup! sandbox: enable keytoc in hosttools_defconfig
      https://git.pengutronix.de/cgit/barebox/commit/?id=31ad2409dd1b (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>

Re: [PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig

[Thomas Bonnefille]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

Hello, thank you very much for this fix !

On Thu Aug 6, 2026 at 3:04 PM CEST, Sascha Hauer wrote:
>
> On Wed, 05 Aug 2026 16:20:02 +0200, Ahmad Fatoum wrote:
>> ci: musl-tools: disable KEYTOC as it depends on OpenSSL
>> 
>> The OpenSSL we ship in the CI container is built against glibc and so
>> compiling keytoc against musl in it is currently not possible.
>> 
>> Fix the CI breakage by disable KEYTOC, but only for the Github workflow.

I’ve successfully compiled OpenSSL against musl in a modified version of
the barebox-ci container and can now compile keytoc in it. This approach
would help detect build errors for keytoc + musl earlier. 

Would this be acceptable for Barebox?

> [...]

Best regards,

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig

[Ahmad Fatoum]

Hello Thomas,

On 8/6/26 16:52, Thomas Bonnefille wrote:
> Hello, thank you very much for this fix !
> 
> On Thu Aug 6, 2026 at 3:04 PM CEST, Sascha Hauer wrote:
>>
>> On Wed, 05 Aug 2026 16:20:02 +0200, Ahmad Fatoum wrote:
>>> ci: musl-tools: disable KEYTOC as it depends on OpenSSL
>>>
>>> The OpenSSL we ship in the CI container is built against glibc and so
>>> compiling keytoc against musl in it is currently not possible.
>>>
>>> Fix the CI breakage by disable KEYTOC, but only for the Github workflow.
> 
> I’ve successfully compiled OpenSSL against musl in a modified version of
> the barebox-ci container and can now compile keytoc in it. This approach
> would help detect build errors for keytoc + musl earlier. 
> 
> Would this be acceptable for Barebox?

Sure, that would be even better!

Thanks,
Ahmad

> 
>> [...]
> 
> Best regards,


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig

[Thomas Bonnefille]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

Hello, thank you very much for this fix !

On Thu Aug 6, 2026 at 3:04 PM CEST, Sascha Hauer wrote:
>
> On Wed, 05 Aug 2026 16:20:02 +0200, Ahmad Fatoum wrote:
>> ci: musl-tools: disable KEYTOC as it depends on OpenSSL
>> 
>> The OpenSSL we ship in the CI container is built against glibc and so
>> compiling keytoc against musl in it is currently not possible.
>> 
>> Fix the CI breakage by disable KEYTOC, but only for the Github workflow.

I’ve successfully compiled OpenSSL against musl in a revised version of the
barebox-ci container and can now compile keytoc in it. This approach would
help detect build errors for keytoc + musl earlier. 
Would this be acceptable for Barebox?

> [...]

Best regards,

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]