mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig
@ 2026-08-05 14:20 Ahmad Fatoum
  2026-08-06 13:04 ` Sascha Hauer
  0 siblings, 1 reply; 5+ messages in thread
From: Ahmad Fatoum @ 2026-08-05 14:20 UTC (permalink / raw)
  To: barebox
  Cc: Thomas Bonnefille, Thomas Petazzoni, Miquèl Raynal, Ahmad Fatoum

ci: musl-tools: disable KEYTOC as it depends on OpenSSL

The OpenSSL we ship in the CI container is built against glibc and so
compiling keytoc against musl in it is currently not possible.

Fix the CI breakage by disable KEYTOC, but only for the Github workflow.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Patch is not yet on master branch, so this could be simply squashed.

 .github/workflows/musl-tools.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.github/workflows/musl-tools.yml b/.github/workflows/musl-tools.yml
index 52cdd184ade3..d85328bc3f3c 100644
--- a/.github/workflows/musl-tools.yml
+++ b/.github/workflows/musl-tools.yml
@@ -34,6 +34,10 @@ jobs:
         m () { make -j$(nproc) CC=musl-gcc LD=musl-gcc HOSTCC=musl-gcc HOSTLD=musl-ld "$@"; }
 
         m ${{matrix.defconfig}}
+
+        # CI image ships OpenSSL development files only for glibc
+        scripts/config --disable KEYTOC
+
         m scripts/
 
         test -n "$(musl-ldd scripts/imx/imx-usb-loader${{matrix.suffix}} 2>/dev/null | grep musl)"
-- 
2.47.3




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig
  2026-08-05 14:20 [PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig Ahmad Fatoum
@ 2026-08-06 13:04 ` Sascha Hauer
  2026-08-06 14:52   ` Thomas Bonnefille
  2026-08-06 14:54   ` Thomas Bonnefille
  0 siblings, 2 replies; 5+ messages in thread
From: Sascha Hauer @ 2026-08-06 13:04 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum
  Cc: Thomas Bonnefille, Thomas Petazzoni, Miquèl Raynal


On Wed, 05 Aug 2026 16:20:02 +0200, Ahmad Fatoum wrote:
> ci: musl-tools: disable KEYTOC as it depends on OpenSSL
> 
> The OpenSSL we ship in the CI container is built against glibc and so
> compiling keytoc against musl in it is currently not possible.
> 
> Fix the CI breakage by disable KEYTOC, but only for the Github workflow.
> 
> [...]

Applied, thanks!

[1/1] fixup! sandbox: enable keytoc in hosttools_defconfig
      https://git.pengutronix.de/cgit/barebox/commit/?id=31ad2409dd1b (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig
  2026-08-06 13:04 ` Sascha Hauer
@ 2026-08-06 14:52   ` Thomas Bonnefille
  2026-08-06 15:38     ` Ahmad Fatoum
  2026-08-06 14:54   ` Thomas Bonnefille
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Bonnefille @ 2026-08-06 14:52 UTC (permalink / raw)
  To: Sascha Hauer, barebox, Ahmad Fatoum
  Cc: Thomas Bonnefille, Thomas Petazzoni, Miquèl Raynal

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

Hello, thank you very much for this fix !

On Thu Aug 6, 2026 at 3:04 PM CEST, Sascha Hauer wrote:
>
> On Wed, 05 Aug 2026 16:20:02 +0200, Ahmad Fatoum wrote:
>> ci: musl-tools: disable KEYTOC as it depends on OpenSSL
>> 
>> The OpenSSL we ship in the CI container is built against glibc and so
>> compiling keytoc against musl in it is currently not possible.
>> 
>> Fix the CI breakage by disable KEYTOC, but only for the Github workflow.

I’ve successfully compiled OpenSSL against musl in a modified version of
the barebox-ci container and can now compile keytoc in it. This approach
would help detect build errors for keytoc + musl earlier. 

Would this be acceptable for Barebox?

> [...]

Best regards,

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig
  2026-08-06 13:04 ` Sascha Hauer
  2026-08-06 14:52   ` Thomas Bonnefille
@ 2026-08-06 14:54   ` Thomas Bonnefille
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas Bonnefille @ 2026-08-06 14:54 UTC (permalink / raw)
  To: Sascha Hauer, barebox, Ahmad Fatoum
  Cc: Thomas Bonnefille, Thomas Petazzoni, Miquèl Raynal

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

Hello, thank you very much for this fix !

On Thu Aug 6, 2026 at 3:04 PM CEST, Sascha Hauer wrote:
>
> On Wed, 05 Aug 2026 16:20:02 +0200, Ahmad Fatoum wrote:
>> ci: musl-tools: disable KEYTOC as it depends on OpenSSL
>> 
>> The OpenSSL we ship in the CI container is built against glibc and so
>> compiling keytoc against musl in it is currently not possible.
>> 
>> Fix the CI breakage by disable KEYTOC, but only for the Github workflow.

I’ve successfully compiled OpenSSL against musl in a revised version of the
barebox-ci container and can now compile keytoc in it. This approach would
help detect build errors for keytoc + musl earlier. 
Would this be acceptable for Barebox?

> [...]

Best regards,

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig
  2026-08-06 14:52   ` Thomas Bonnefille
@ 2026-08-06 15:38     ` Ahmad Fatoum
  0 siblings, 0 replies; 5+ messages in thread
From: Ahmad Fatoum @ 2026-08-06 15:38 UTC (permalink / raw)
  To: Thomas Bonnefille, Sascha Hauer, barebox
  Cc: Thomas Petazzoni, Miquèl Raynal

Hello Thomas,

On 8/6/26 16:52, Thomas Bonnefille wrote:
> Hello, thank you very much for this fix !
> 
> On Thu Aug 6, 2026 at 3:04 PM CEST, Sascha Hauer wrote:
>>
>> On Wed, 05 Aug 2026 16:20:02 +0200, Ahmad Fatoum wrote:
>>> ci: musl-tools: disable KEYTOC as it depends on OpenSSL
>>>
>>> The OpenSSL we ship in the CI container is built against glibc and so
>>> compiling keytoc against musl in it is currently not possible.
>>>
>>> Fix the CI breakage by disable KEYTOC, but only for the Github workflow.
> 
> I’ve successfully compiled OpenSSL against musl in a modified version of
> the barebox-ci container and can now compile keytoc in it. This approach
> would help detect build errors for keytoc + musl earlier. 
> 
> Would this be acceptable for Barebox?

Sure, that would be even better!

Thanks,
Ahmad

> 
>> [...]
> 
> Best regards,


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-08-06 15:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-05 14:20 [PATCH] fixup! sandbox: enable keytoc in hosttools_defconfig Ahmad Fatoum
2026-08-06 13:04 ` Sascha Hauer
2026-08-06 14:52   ` Thomas Bonnefille
2026-08-06 15:38     ` Ahmad Fatoum
2026-08-06 14:54   ` Thomas Bonnefille

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox