[PATCH master 1/2] defaultenv: bin/devboot: fix typo in final exit

[PATCH master 1/2] defaultenv: bin/devboot: fix typo in final exit

[Ahmad Fatoum]

From: Ahmad Fatoum <a.fatoum@barebox.org>

The script now ends with "ecit $ret" instead of "exit $ret", so every
devboot whose boot command returns prints "ecit: Command not found"
and exits with 127 instead of the status of the boot command.

Fix the typo and add the missing newline at the end of the file.

Fixes: 90fb96609ef7 ("defaultenv: bin/devboot: propagate exit status of boot command")
Assisted-by: Claude:opus-5.5
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
 defaultenv/defaultenv-2-base/bin/devboot | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/defaultenv/defaultenv-2-base/bin/devboot b/defaultenv/defaultenv-2-base/bin/devboot
index 2752e8d7794c..1a4324633769 100644
--- a/defaultenv/defaultenv-2-base/bin/devboot
+++ b/defaultenv/defaultenv-2-base/bin/devboot
@@ -49,4 +49,4 @@ ret=$?
 global -r "linux.bootargs.devboot.*"
 cd "${saved_pwd}"
 
-ecit $ret
\ No newline at end of file
+exit $ret
-- 
2.47.3

[PATCH master 2/2] defaultenv: devboot: use rsinit.bind_modules to bind mount modules

[Ahmad Fatoum]

From: Ahmad Fatoum <a.fatoum@barebox.org>

The rsinit-modules snippet and the devboot documentation pass
rsinit.bind=/lib/modules on the kernel command line, but rsinit only
knows the rsinit.bind_modules flag and silently ignores unknown
options. The modules CPIO is thus unpacked into the initramfs, but
never bind mounted over the root file system's /lib/modules.

Switch both over to rsinit.bind_modules.

Link: https://github.com/pengutronix/rsinit#bind-mounting-kernel-modules-from-initrd
Fixes: 1003a9d70373 ("defaultenv: base: add new devboot script")
Fixes: fc586dda711c ("defaultenv: add optional devboot snippets under /env/devboot/")
Assisted-by: Claude:opus-5.5
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
 Documentation/user/devboot.rst                         | 4 ++--
 defaultenv/defaultenv-2-devboot/devboot/rsinit-modules | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/user/devboot.rst b/Documentation/user/devboot.rst
index 28a2f65192d6..a55be7e305f2 100644
--- a/Documentation/user/devboot.rst
+++ b/Documentation/user/devboot.rst
@@ -173,7 +173,7 @@ kernel command line fragments:
   devboot_oftree=
   devboot_initrd=":afa-modules-arm64"
 
-  global linux.bootargs.devboot.rsinit="rsinit.bind=/lib/modules"
+  global linux.bootargs.devboot.rsinit="rsinit.bind_modules"
 
 With this script in place and ``global.user=afa``, ``global.hostname=rock3a``,
 running ``devboot mmc`` on the board expands to::
@@ -222,7 +222,7 @@ which the configuration script can source instead of spelling them out:
 ``/env/devboot/rsinit-modules``
   Appends the ``${global.user}-modules-${global.arch}`` CPIO archive to
   the initrd, as built by the Linux kernel ``make modules-cpio-pkg``
-  target, and adds ``rsinit.bind=/lib/modules`` to the kernel command
+  target, and adds ``rsinit.bind_modules`` to the kernel command
   line, so that the rsinit init in the initramfs bind mounts the modules
   over the root file system's ``/lib/modules``.
 
diff --git a/defaultenv/defaultenv-2-devboot/devboot/rsinit-modules b/defaultenv/defaultenv-2-devboot/devboot/rsinit-modules
index 3ada2dfeac39..b47d2e2739eb 100644
--- a/defaultenv/defaultenv-2-devboot/devboot/rsinit-modules
+++ b/defaultenv/defaultenv-2-devboot/devboot/rsinit-modules
@@ -1,4 +1,4 @@
 # Append the module CPIO archive and rsinit bind mount them over /lib/modules
 
 devboot_initrd="${devboot_initrd}:${global.user}-modules-${global.arch}"
-global linux.bootargs.devboot.rsinit="rsinit.bind=/lib/modules"
+global linux.bootargs.devboot.rsinit="rsinit.bind_modules"
-- 
2.47.3

Re: [PATCH master 1/2] defaultenv: bin/devboot: fix typo in final exit

[Sascha Hauer]

On Thu, 15 Oct 2026 13:07:00 +0200, Ahmad Fatoum wrote:
> The script now ends with "ecit $ret" instead of "exit $ret", so every
> devboot whose boot command returns prints "ecit: Command not found"
> and exits with 127 instead of the status of the boot command.
> 
> Fix the typo and add the missing newline at the end of the file.
> 
> 
> [...]

Applied, thanks!

[1/2] defaultenv: bin/devboot: fix typo in final exit
      https://git.pengutronix.de/cgit/barebox/commit/?id=6e55c427892d (link may not be stable)
[2/2] defaultenv: devboot: use rsinit.bind_modules to bind mount modules
      https://git.pengutronix.de/cgit/barebox/commit/?id=7c9d54c707b4 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>