nios2 and openrisc in barebox

nios2 and openrisc in barebox

[Sascha Hauer]

Hi Franck, Antony

Are you still interested in barebox support for NIOS2 and openrisc? If
not I would consider removing it. Background is that we are planning to
introduce green threads and implement pollers with them which makes
green threads rather mandatory. Green threads need a setjmp/longjmp
implementation that would have to be added for these architectures.

Keeping the architectures is no big deal normally, but I don't want to
add untested new functionality, also I don't want to implement things
that nobody uses, so if you are still interested it would be great if
you volunteer to implement setjmp/longjmp.

Thanks
  Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Franck Jullien]

Le mar. 23 févr. 2021 à 10:59, Sascha Hauer <sha@pengutronix.de> a écrit :
>
> Hi Franck, Antony
>
> Are you still interested in barebox support for NIOS2 and openrisc? If
> not I would consider removing it. Background is that we are planning to
> introduce green threads and implement pollers with them which makes
> green threads rather mandatory. Green threads need a setjmp/longjmp
> implementation that would have to be added for these architectures.
>
> Keeping the architectures is no big deal normally, but I don't want to
> add untested new functionality, also I don't want to implement things
> that nobody uses, so if you are still interested it would be great if
> you volunteer to implement setjmp/longjmp.
>
> Thanks
>   Sascha
>

Hi,

Thanks for asking.

I don't think anyone is using (has ever used ?) Barebox on these architectures.

I do have a product which uses Barebox and a NIOS2 in the field.
It's working for 10+ years already but will never be updated.

I think you can drop support for them. I won't work on this myself.
Let's wait for Antony's view on this.

Franck.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Antony Pavlov]

On Tue, 23 Feb 2021 14:13:44 +0100
Franck Jullien <franck.jullien@gmail.com> wrote:

> Le mar. 23 févr. 2021 à 10:59, Sascha Hauer <sha@pengutronix.de> a écrit :
> >
> > Hi Franck, Antony
> >
> > Are you still interested in barebox support for NIOS2 and openrisc? If
> > not I would consider removing it. Background is that we are planning to
> > introduce green threads and implement pollers with them which makes
> > green threads rather mandatory. Green threads need a setjmp/longjmp
> > implementation that would have to be added for these architectures.
> >
> > Keeping the architectures is no big deal normally, but I don't want to
> > add untested new functionality, also I don't want to implement things
> > that nobody uses, so if you are still interested it would be great if
> > you volunteer to implement setjmp/longjmp.
> >
> > Thanks
> >   Sascha
> >
> 
> Hi,
> 
> Thanks for asking.
> 
> I don't think anyone is using (has ever used ?) Barebox on these architectures.
> 
> I do have a product which uses Barebox and a NIOS2 in the field.
> It's working for 10+ years already but will never be updated.
> 
> I think you can drop support for them. I won't work on this myself.
> Let's wait for Antony's view on this.

Hi!

I experimented with openrisc before widespread use of RISC-V.
I have never used nios2.

IMHO we can drop openrisc and nios2.

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Sascha Hauer]

On Wed, Feb 24, 2021 at 10:06:46AM +0300, Antony Pavlov wrote:
> On Tue, 23 Feb 2021 14:13:44 +0100
> Franck Jullien <franck.jullien@gmail.com> wrote:
> 
> > Le mar. 23 févr. 2021 à 10:59, Sascha Hauer <sha@pengutronix.de> a écrit :
> > >
> > > Hi Franck, Antony
> > >
> > > Are you still interested in barebox support for NIOS2 and openrisc? If
> > > not I would consider removing it. Background is that we are planning to
> > > introduce green threads and implement pollers with them which makes
> > > green threads rather mandatory. Green threads need a setjmp/longjmp
> > > implementation that would have to be added for these architectures.
> > >
> > > Keeping the architectures is no big deal normally, but I don't want to
> > > add untested new functionality, also I don't want to implement things
> > > that nobody uses, so if you are still interested it would be great if
> > > you volunteer to implement setjmp/longjmp.
> > >
> > > Thanks
> > >   Sascha
> > >
> > 
> > Hi,
> > 
> > Thanks for asking.
> > 
> > I don't think anyone is using (has ever used ?) Barebox on these architectures.
> > 
> > I do have a product which uses Barebox and a NIOS2 in the field.
> > It's working for 10+ years already but will never be updated.
> > 
> > I think you can drop support for them. I won't work on this myself.
> > Let's wait for Antony's view on this.
> 
> Hi!
> 
> I experimented with openrisc before widespread use of RISC-V.
> I have never used nios2.
> 
> IMHO we can drop openrisc and nios2.

Ok, thanks for your input. Let's go for it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Yann Sionneau]

Hello,

I am adding Stafford Horne in CC, as I think he might want to help about 
openrisc port :)

Cheers

Yann

On 23/02/2021 10:59, Sascha Hauer wrote:
> Hi Franck, Antony
>
> Are you still interested in barebox support for NIOS2 and openrisc? If
> not I would consider removing it. Background is that we are planning to
> introduce green threads and implement pollers with them which makes
> green threads rather mandatory. Green threads need a setjmp/longjmp
> implementation that would have to be added for these architectures.
>
> Keeping the architectures is no big deal normally, but I don't want to
> add untested new functionality, also I don't want to implement things
> that nobody uses, so if you are still interested it would be great if
> you volunteer to implement setjmp/longjmp.
>
> Thanks
>    Sascha
>


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Stafford Horne]

Hello,

On Thu, Feb 25, 2021 at 08:17:41AM +0100, Yann Sionneau wrote:
> Hello,
> 
> I am adding Stafford Horne in CC, as I think he might want to help about
> openrisc port :)
> 
> Cheers
> 
> Yann
> 
> On 23/02/2021 10:59, Sascha Hauer wrote:
> > Hi Franck, Antony
> > 
> > Are you still interested in barebox support for NIOS2 and openrisc? If
> > not I would consider removing it. Background is that we are planning to
> > introduce green threads and implement pollers with them which makes
> > green threads rather mandatory. Green threads need a setjmp/longjmp
> > implementation that would have to be added for these architectures.
> > 
> > Keeping the architectures is no big deal normally, but I don't want to
> > add untested new functionality, also I don't want to implement things
> > that nobody uses, so if you are still interested it would be great if
> > you volunteer to implement setjmp/longjmp.

I am the maintainer of most OpenRISC things right now.  I would be happy to
help, but I don't really use barebox right now.  Most of my deployments I use
with litex FPGA SoC's that has its own bootloader.

That said, we have a setjmp/longjmp implementation in our glibc port which I
have been testing for upstreaming lately.

  https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/setjmp.S
  https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/__longjmp.S

I had a look at the barebox docs and openrisc port, it seems like there is
support for our standard platform, or1ksim, which is the same as my de0-nano
fpga board/soc and qemu.  I should be able to make use of this.

Is there a branch where you are doing the green thread work?  I could add and
test the OpenRISC implementation.

-Stafford

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Jules Maselbas]

On Thu, Feb 25, 2021 at 09:45:00PM +0900, Stafford Horne wrote:
> Hello,
> 
> I am the maintainer of most OpenRISC things right now.  I would be happy to
> help, but I don't really use barebox right now.  Most of my deployments I use
> with litex FPGA SoC's that has its own bootloader.
> 
> That said, we have a setjmp/longjmp implementation in our glibc port which I
> have been testing for upstreaming lately.
> 
>   https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/setjmp.S
>   https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/__longjmp.S
> 
> I had a look at the barebox docs and openrisc port, it seems like there is
> support for our standard platform, or1ksim, which is the same as my de0-nano
> fpga board/soc and qemu.  I should be able to make use of this.
> 
> Is there a branch where you are doing the green thread work?  I could add and
> test the OpenRISC implementation.
Hi,

I've done this yesterday, I've push a branch[1] that has the green
thread paches applied (except patches on usb mass storage gadget).
https://github.com/jmaselbas/barebox/tree/test_setjmp 

To test greenthread your can run the `poller -c` command in barebox's
prompt. To do you you'll need to enable CONFIG_POLLER_YIELD and define
CONFIG_HAS_ARCH_SJLJ

Best,
Jules
 


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Ahmad Fatoum]

Hello,

On 25.02.21 14:02, Jules Maselbas wrote:
> On Thu, Feb 25, 2021 at 09:45:00PM +0900, Stafford Horne wrote:
>> Hello,
>>
>> I am the maintainer of most OpenRISC things right now.  I would be happy to
>> help, but I don't really use barebox right now.  Most of my deployments I use
>> with litex FPGA SoC's that has its own bootloader.
>>
>> That said, we have a setjmp/longjmp implementation in our glibc port which I
>> have been testing for upstreaming lately.
>>
>>   https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/setjmp.S
>>   https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/__longjmp.S
>>
>> I had a look at the barebox docs and openrisc port, it seems like there is
>> support for our standard platform, or1ksim, which is the same as my de0-nano
>> fpga board/soc and qemu.  I should be able to make use of this.
>>
>> Is there a branch where you are doing the green thread work?  I could add and
>> test the OpenRISC implementation.
> Hi,
> 
> I've done this yesterday, I've push a branch[1] that has the green
> thread paches applied (except patches on usb mass storage gadget).
> https://github.com/jmaselbas/barebox/tree/test_setjmp 

Great. Thanks. I'm preparing an updated version that will clean it up
a bit, but the heart part of architectures providing setjmp/longjmp/initjmp
will stay the same.

Small request:
  If you implement initjmp, could you have it save into jmp_buf a frame
  pointer value of NULL if applicable? That way, should backtrace be
  implemented (or done via JTAG), they have a defined end.

Cheers,
Ahmad

> To test greenthread your can run the `poller -c` command in barebox's
> prompt. To do you you'll need to enable CONFIG_POLLER_YIELD and define
> CONFIG_HAS_ARCH_SJLJ
> 
> Best,
> Jules
>  
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Antony Pavlov]

On Thu, 25 Feb 2021 16:33:06 +0100
Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:

> Hello,
> 
> On 25.02.21 14:02, Jules Maselbas wrote:
> > On Thu, Feb 25, 2021 at 09:45:00PM +0900, Stafford Horne wrote:
> >> Hello,
> >>
> >> I am the maintainer of most OpenRISC things right now.  I would be happy to
> >> help, but I don't really use barebox right now.  Most of my deployments I use
> >> with litex FPGA SoC's that has its own bootloader.
> >>

There is barebox for litex SoC with RISC-V CPU core, please see:

https://github.com/enjoy-digital/litex/issues/413#issuecomment-609047340

> >> That said, we have a setjmp/longjmp implementation in our glibc port which I
> >> have been testing for upstreaming lately.
> >>
> >>   https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/setjmp.S
> >>   https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/__longjmp.S
> >>
> >> I had a look at the barebox docs and openrisc port, it seems like there is
> >> support for our standard platform, or1ksim, which is the same as my de0-nano
> >> fpga board/soc and qemu.  I should be able to make use of this.
> >>
> >> Is there a branch where you are doing the green thread work?  I could add and
> >> test the OpenRISC implementation.
> > Hi,
> > 
> > I've done this yesterday, I've push a branch[1] that has the green
> > thread paches applied (except patches on usb mass storage gadget).
> > https://github.com/jmaselbas/barebox/tree/test_setjmp 
> 
> Great. Thanks. I'm preparing an updated version that will clean it up
> a bit, but the heart part of architectures providing setjmp/longjmp/initjmp
> will stay the same.
> 
> Small request:
>   If you implement initjmp, could you have it save into jmp_buf a frame
>   pointer value of NULL if applicable? That way, should backtrace be
>   implemented (or done via JTAG), they have a defined end.
> 
> Cheers,
> Ahmad
> 
> > To test greenthread your can run the `poller -c` command in barebox's
> > prompt. To do you you'll need to enable CONFIG_POLLER_YIELD and define
> > CONFIG_HAS_ARCH_SJLJ
> > 
> > Best,
> > Jules
> >  
> > 
> > 
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Stafford Horne]

On Thu, Feb 25, 2021 at 08:39:20PM +0300, Antony Pavlov wrote:
> On Thu, 25 Feb 2021 16:33:06 +0100
> Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> 
> > Hello,
> > 
> > On 25.02.21 14:02, Jules Maselbas wrote:
> > > On Thu, Feb 25, 2021 at 09:45:00PM +0900, Stafford Horne wrote:
> > >> Hello,
> > >>
> > >> I am the maintainer of most OpenRISC things right now.  I would be happy to
> > >> help, but I don't really use barebox right now.  Most of my deployments I use
> > >> with litex FPGA SoC's that has its own bootloader.
> > >>
> 
> There is barebox for litex SoC with RISC-V CPU core, please see:
> 
> https://github.com/enjoy-digital/litex/issues/413#issuecomment-609047340

Hi Antony,

Great thanks, I see that is a two stage bootloader Litex BIOS -> Barebox.
That's great and gives me an easier target.

-Stafford

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Ahmad Fatoum]

Hello,

On 25.02.21 16:33, Ahmad Fatoum wrote:

> On 25.02.21 14:02, Jules Maselbas wrote:
>> On Thu, Feb 25, 2021 at 09:45:00PM +0900, Stafford Horne wrote:
>>> Hello,
>>>
>>> I am the maintainer of most OpenRISC things right now.  I would be happy to
>>> help, but I don't really use barebox right now.  Most of my deployments I use
>>> with litex FPGA SoC's that has its own bootloader.
>>>
>>> That said, we have a setjmp/longjmp implementation in our glibc port which I
>>> have been testing for upstreaming lately.
>>>
>>>   https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/setjmp.S
>>>   https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/__longjmp.S
>>>
>>> I had a look at the barebox docs and openrisc port, it seems like there is
>>> support for our standard platform, or1ksim, which is the same as my de0-nano
>>> fpga board/soc and qemu.  I should be able to make use of this.
>>>
>>> Is there a branch where you are doing the green thread work?  I could add and
>>> test the OpenRISC implementation.
>> Hi,
>>
>> I've done this yesterday, I've push a branch[1] that has the green
>> thread paches applied (except patches on usb mass storage gadget).
>> https://github.com/jmaselbas/barebox/tree/test_setjmp 
> 
> Great. Thanks. I'm preparing an updated version that will clean it up
> a bit, but the heart part of architectures providing setjmp/longjmp/initjmp
> will stay the same.
> 
> Small request:
>   If you implement initjmp, could you have it save into jmp_buf a frame
>   pointer value of NULL if applicable? That way, should backtrace be
>   implemented (or done via JTAG), they have a defined end.

Dismiss this last request. C code will just zero-initialize jmp_buf,
so initjmp needs only fill out return address and stack pointer. I just
sent out a series, which can be used to develop this one.

@Jules, any chance you could take over the kvx port? :-)

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Jules Maselbas]

Hi Ahmad,

On Mon, Mar 01, 2021 at 12:05:35PM +0100, Ahmad Fatoum wrote:
> Hello,
> 
> > Small request:
> >   If you implement initjmp, could you have it save into jmp_buf a frame
> >   pointer value of NULL if applicable? That way, should backtrace be
> >   implemented (or done via JTAG), they have a defined end.
> 
> Dismiss this last request. C code will just zero-initialize jmp_buf,
> so initjmp needs only fill out return address and stack pointer. I just
> sent out a series, which can be used to develop this one.
> 
> @Jules, any chance you could take over the kvx port? :-)
Yes, I've got a patch almost ready to be sent.

Jules 


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: nios2 and openrisc in barebox

[Stafford Horne]

On Mon, Mar 01, 2021 at 12:05:35PM +0100, Ahmad Fatoum wrote:
> Hello,
> 
> On 25.02.21 16:33, Ahmad Fatoum wrote:
> 
> > On 25.02.21 14:02, Jules Maselbas wrote:
> >> On Thu, Feb 25, 2021 at 09:45:00PM +0900, Stafford Horne wrote:
> >>> Hello,
> >>>
> >>> I am the maintainer of most OpenRISC things right now.  I would be happy to
> >>> help, but I don't really use barebox right now.  Most of my deployments I use
> >>> with litex FPGA SoC's that has its own bootloader.
> >>>
> >>> That said, we have a setjmp/longjmp implementation in our glibc port which I
> >>> have been testing for upstreaming lately.
> >>>
> >>>   https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/setjmp.S
> >>>   https://github.com/stffrdhrn/or1k-glibc/blob/or1k-port-2/sysdeps/or1k/__longjmp.S
> >>>
> >>> I had a look at the barebox docs and openrisc port, it seems like there is
> >>> support for our standard platform, or1ksim, which is the same as my de0-nano
> >>> fpga board/soc and qemu.  I should be able to make use of this.
> >>>
> >>> Is there a branch where you are doing the green thread work?  I could add and
> >>> test the OpenRISC implementation.
> >> Hi,
> >>
> >> I've done this yesterday, I've push a branch[1] that has the green
> >> thread paches applied (except patches on usb mass storage gadget).
> >> https://github.com/jmaselbas/barebox/tree/test_setjmp 
> > 
> > Great. Thanks. I'm preparing an updated version that will clean it up
> > a bit, but the heart part of architectures providing setjmp/longjmp/initjmp
> > will stay the same.
> > 
> > Small request:
> >   If you implement initjmp, could you have it save into jmp_buf a frame
> >   pointer value of NULL if applicable? That way, should backtrace be
> >   implemented (or done via JTAG), they have a defined end.
> 
> Dismiss this last request. C code will just zero-initialize jmp_buf,
> so initjmp needs only fill out return address and stack pointer. I just
> sent out a series, which can be used to develop this one.

Thanks,

I will start looking at this now, I'll let you know when I get progress on
openrisc.

> @Jules, any chance you could take over the kvx port? :-)
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox