From: Sascha Hauer <s.hauer@pengutronix.de> To: Barebox List <barebox@lists.infradead.org> Cc: Marco Felsch <m.felsch@pengutronix.de> Subject: [PATCH 02/19] of: platform: remove check of already added devices Date: Fri, 25 Jun 2021 09:25:23 +0200 [thread overview] Message-ID: <20210625072540.32717-3-s.hauer@pengutronix.de> (raw) In-Reply-To: <20210625072540.32717-1-s.hauer@pengutronix.de> From: Marco Felsch <m.felsch@pengutronix.de> This check is a relict of the early barebox device tree days, where devices were added by machine and/or board code too. The check ensured too not populate the same device twice. Nowadays _real_ hardware devices (devices with hardware resources) which are not auto enumerable should only be added using the device tree. Remove the check to cleanup the code and to remove looping over each device every time of_platform_device_create() is called instead of keeping it for legacy boards/machines. Those legacy boards/machines should be converted instead. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> Link: https://lore.pengutronix.de/20201021115813.31645-3-m.felsch@pengutronix.de Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- drivers/of/platform.c | 31 +------------------------------ 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 21c7cce1a5..51781798c6 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -101,7 +101,7 @@ struct device_d *of_platform_device_create(struct device_node *np, struct device_d *dev; struct resource *res = NULL, temp_res; resource_size_t resinval; - int i, j, ret, num_reg = 0, match; + int i, ret, num_reg = 0; if (!of_device_is_available(np)) return NULL; @@ -121,35 +121,6 @@ struct device_d *of_platform_device_create(struct device_node *np, return NULL; } } - - /* - * A device may already be registered as platform_device. - * Instead of registering the same device again, just - * add this node to the existing device. - */ - for_each_device(dev) { - if (!dev->resource) - continue; - - for (i = 0, match = 0; i < num_reg; i++) - for (j = 0; j < dev->num_resources; j++) - if (dev->resource[j].start == - res[i].start && - dev->resource[j].end == - res[i].end) { - match++; - break; - } - - /* check if all address resources match */ - if (match == num_reg) { - debug("connecting %s to %s\n", - np->name, dev_name(dev)); - dev->device_node = np; - free(res); - return dev; - } - } } /* setup generic device info */ -- 2.29.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-06-25 7:46 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-25 7:25 [PATCH v6 00/19] barebox deep probe support Sascha Hauer 2021-06-25 7:25 ` [PATCH 01/19] imx53: remove unused imx53_add_nand Sascha Hauer 2021-06-25 7:25 ` Sascha Hauer [this message] 2021-06-25 7:25 ` [PATCH 03/19] of: platform: Keep track of populated platform devices Sascha Hauer 2021-06-25 7:25 ` [PATCH 04/19] of: base: move memory init from DT to initcall Sascha Hauer 2021-06-25 7:25 ` [PATCH 05/19] of: base: move clock init from of_probe() to barebox_register_of() Sascha Hauer 2021-06-25 7:25 ` [PATCH 06/19] of: Set of_chosen and of_model earlier Sascha Hauer 2021-06-25 7:25 ` [PATCH 07/19] of: implement of_get_stdoutpath() Sascha Hauer 2021-06-25 7:25 ` [PATCH 08/19] initcall: add of_populate_initcall Sascha Hauer 2021-06-25 7:25 ` [PATCH 09/19] common: add initial barebox deep-probe support Sascha Hauer 2021-06-25 7:25 ` [PATCH 10/19] pinctrl: Find controller node first Sascha Hauer 2021-06-25 7:25 ` [PATCH 11/19] common: Explicitly probe consoles earlier with deep probe Sascha Hauer 2021-06-25 7:25 ` [PATCH 12/19] pinctrl: Add deep probe support Sascha Hauer 2021-06-25 7:25 ` [PATCH 13/19] phy: " Sascha Hauer 2021-06-25 7:25 ` [PATCH 14/19] ARM: i.MX: esdctl: add deep-probe support Sascha Hauer 2021-06-25 7:25 ` [PATCH 15/19] ARM: stm32mp: ddrctrl: " Sascha Hauer 2021-06-25 7:25 ` [PATCH 16/19] ARM: boards: mx6-sabrelite: " Sascha Hauer 2021-06-25 7:25 ` [PATCH 17/19] ARM: i.MX Phytec physom: convert to board driver Sascha Hauer 2021-06-25 7:25 ` [PATCH 18/19] ARM: i.MX Phytec physom: Add deep-probe support Sascha Hauer 2021-06-25 7:25 ` [PATCH 19/19] of: Add dummy driver Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210625072540.32717-3-s.hauer@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=m.felsch@pengutronix.de \ --subject='Re: [PATCH 02/19] of: platform: remove check of already added devices' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox