mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 10/19] pinctrl: Find controller node first
Date: Fri, 25 Jun 2021 09:25:31 +0200	[thread overview]
Message-ID: <20210625072540.32717-11-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20210625072540.32717-1-s.hauer@pengutronix.de>

The pinctrl controller node is the first parent node that has a compatible
property. Use that information to find the node without iterating up to
the root node.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/pinctrl/pinctrl.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/pinctrl.c b/drivers/pinctrl/pinctrl.c
index b36521ef83..84ac61f2d9 100644
--- a/drivers/pinctrl/pinctrl.c
+++ b/drivers/pinctrl/pinctrl.c
@@ -85,12 +85,15 @@ static int pinctrl_config_one(struct device_node *np)
 		pinctrl_node = pinctrl_node->parent;
 		if (!pinctrl_node)
 			return -ENODEV;
-		pdev = find_pinctrl(pinctrl_node);
-		if (pdev)
+		if (of_get_property(pinctrl_node, "compatible", NULL))
 			break;
 	}
 
-	return pdev->ops->set_state(pdev, np);
+	pdev = find_pinctrl(pinctrl_node);
+	if (pdev)
+		return pdev->ops->set_state(pdev, np);
+	else
+		return -ENODEV;
 }
 
 int of_pinctrl_select_state(struct device_node *np, const char *name)
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  parent reply	other threads:[~2021-06-25  7:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  7:25 [PATCH v6 00/19] barebox deep probe support Sascha Hauer
2021-06-25  7:25 ` [PATCH 01/19] imx53: remove unused imx53_add_nand Sascha Hauer
2021-06-25  7:25 ` [PATCH 02/19] of: platform: remove check of already added devices Sascha Hauer
2021-06-25  7:25 ` [PATCH 03/19] of: platform: Keep track of populated platform devices Sascha Hauer
2021-06-25  7:25 ` [PATCH 04/19] of: base: move memory init from DT to initcall Sascha Hauer
2021-06-25  7:25 ` [PATCH 05/19] of: base: move clock init from of_probe() to barebox_register_of() Sascha Hauer
2021-06-25  7:25 ` [PATCH 06/19] of: Set of_chosen and of_model earlier Sascha Hauer
2021-06-25  7:25 ` [PATCH 07/19] of: implement of_get_stdoutpath() Sascha Hauer
2021-06-25  7:25 ` [PATCH 08/19] initcall: add of_populate_initcall Sascha Hauer
2021-06-25  7:25 ` [PATCH 09/19] common: add initial barebox deep-probe support Sascha Hauer
2021-06-25  7:25 ` Sascha Hauer [this message]
2021-06-25  7:25 ` [PATCH 11/19] common: Explicitly probe consoles earlier with deep probe Sascha Hauer
2021-06-25  7:25 ` [PATCH 12/19] pinctrl: Add deep probe support Sascha Hauer
2021-06-25  7:25 ` [PATCH 13/19] phy: " Sascha Hauer
2021-06-25  7:25 ` [PATCH 14/19] ARM: i.MX: esdctl: add deep-probe support Sascha Hauer
2021-06-25  7:25 ` [PATCH 15/19] ARM: stm32mp: ddrctrl: " Sascha Hauer
2021-06-25  7:25 ` [PATCH 16/19] ARM: boards: mx6-sabrelite: " Sascha Hauer
2021-06-25  7:25 ` [PATCH 17/19] ARM: i.MX Phytec physom: convert to board driver Sascha Hauer
2021-06-25  7:25 ` [PATCH 18/19] ARM: i.MX Phytec physom: Add deep-probe support Sascha Hauer
2021-06-25  7:25 ` [PATCH 19/19] of: Add dummy driver Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210625072540.32717-11-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --subject='Re: [PATCH 10/19] pinctrl: Find controller node first' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox