From: "Sascha Hauer" <s.hauer@pengutronix.de>
To: "Ahmad Fatoum" <a.fatoum@pengutronix.de>
Cc: BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH 6/6] mci: sdhci: rockchip: officially support HS200
Date: Thu, 07 May 2026 08:36:53 +0000 [thread overview]
Message-ID: <E1wKuE1-00000005iw8-104H@pty.whiteo.stw.pengutronix.de> (raw)
In-Reply-To: <7cc7c207-bc4f-43b9-a9dc-4939316c4169@pengutronix.de>
On 2026-05-07 10:15, Ahmad Fatoum wrote:
> Hi,
>
> On 5/7/26 9:02 AM, Sascha Hauer wrote:
> > "officially" is meant in the way that even with the SDHCI_QUIRK2_BROKEN_HS200
> > flag set the driver already does HS200 when the device tree mandates it.
>
> Shouldn't we change mci-core.c to evaluate MMC_CAP2_HS200 then?
It already does. The problem is that when the device tree has the
"mmc-hs200-1_8v" property than it's authorative. The SDHCI_QUIRK2_BROKEN_HS200
only prevents the MMC_CAP2_HS200 from being set based on other caps, but
it doesn't clear MMC_CAP2_HS200 when SDHCI_QUIRK2_BROKEN_HS200 is set.
The behaviour is the same as in Linux, so I hesitated from changing this.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2026-05-07 8:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 7:02 [PATCH 0/6] mci: rockchip-dwcmshc: add HS200 support Sascha Hauer
2026-05-07 7:02 ` [PATCH 1/6] mci: sdhci: rockchip: set hidspd before re-enabling the clock Sascha Hauer
2026-05-07 8:05 ` Ahmad Fatoum
2026-05-07 7:02 ` [PATCH 2/6] mci: sdhci: rockchip: disable clock while setting DLL Sascha Hauer
2026-05-07 8:10 ` Ahmad Fatoum
2026-05-07 7:02 ` [PATCH 3/6] mci: sdhci: rockchip: Wait for transfer complete interrupt with MMC_RSP_BUSY cmd Sascha Hauer
2026-05-07 8:11 ` Ahmad Fatoum
2026-05-07 7:02 ` [PATCH 4/6] mci: sdhci: rockchip: Update pre-change delay for rockchip platform Sascha Hauer
2026-05-07 8:12 ` Ahmad Fatoum
2026-05-07 7:02 ` [PATCH 5/6] clk: composite: pick best parent for round_rate / set_rate Sascha Hauer
2026-05-07 7:02 ` [PATCH 6/6] mci: sdhci: rockchip: officially support HS200 Sascha Hauer
2026-05-07 8:15 ` Ahmad Fatoum
2026-05-07 8:36 ` Sascha Hauer [this message]
2026-05-07 7:47 ` [PATCH 0/6] mci: rockchip-dwcmshc: add HS200 support Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1wKuE1-00000005iw8-104H@pty.whiteo.stw.pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox