From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/6] mci: sdhci: rockchip: disable clock while setting DLL
Date: Thu, 7 May 2026 10:10:23 +0200 [thread overview]
Message-ID: <b5f84677-b583-40dc-8cbb-3b033e7b6b95@pengutronix.de> (raw)
In-Reply-To: <20260507-rockchip-emmc-v1-2-5e8109e8059d@pengutronix.de>
On 5/7/26 9:02 AM, Sascha Hauer wrote:
> sdhci_set_clock() enabled the clock. Linux explicitly disables the clock
> after that is called and before the DLL is configured. Do likewise in barebox.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> +enable_clock:
> + sdhci_enable_clk(&host->sdhci, 0);
> +
> + return;
Nit: Redundant return
> }
>
> static void rk_sdhci_set_ios(struct mci_host *mci, struct mci_ios *ios)
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2026-05-07 8:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 7:02 [PATCH 0/6] mci: rockchip-dwcmshc: add HS200 support Sascha Hauer
2026-05-07 7:02 ` [PATCH 1/6] mci: sdhci: rockchip: set hidspd before re-enabling the clock Sascha Hauer
2026-05-07 8:05 ` Ahmad Fatoum
2026-05-07 7:02 ` [PATCH 2/6] mci: sdhci: rockchip: disable clock while setting DLL Sascha Hauer
2026-05-07 8:10 ` Ahmad Fatoum [this message]
2026-05-07 7:02 ` [PATCH 3/6] mci: sdhci: rockchip: Wait for transfer complete interrupt with MMC_RSP_BUSY cmd Sascha Hauer
2026-05-07 8:11 ` Ahmad Fatoum
2026-05-07 7:02 ` [PATCH 4/6] mci: sdhci: rockchip: Update pre-change delay for rockchip platform Sascha Hauer
2026-05-07 8:12 ` Ahmad Fatoum
2026-05-07 7:02 ` [PATCH 5/6] clk: composite: pick best parent for round_rate / set_rate Sascha Hauer
2026-05-07 7:02 ` [PATCH 6/6] mci: sdhci: rockchip: officially support HS200 Sascha Hauer
2026-05-07 8:15 ` Ahmad Fatoum
2026-05-07 8:36 ` Sascha Hauer
2026-05-07 7:47 ` [PATCH 0/6] mci: rockchip-dwcmshc: add HS200 support Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f84677-b583-40dc-8cbb-3b033e7b6b95@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox